jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/403214 )
Change subject: Listen to minerva download events and log events accordingly ...................................................................... Listen to minerva download events and log events accordingly Bug: T181297 Change-Id: I90b2487014c2fdcd18716628502672107c1a7c6f --- M modules/all/ext.wikimediaEvents.print.js 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: jenkins-bot: Verified Jdlrobson: Looks good to me, approved diff --git a/modules/all/ext.wikimediaEvents.print.js b/modules/all/ext.wikimediaEvents.print.js index 6e400d0..fb42944 100644 --- a/modules/all/ext.wikimediaEvents.print.js +++ b/modules/all/ext.wikimediaEvents.print.js @@ -9,7 +9,7 @@ * @see https://phabricator.wikimedia.org/T169730 * @see https://meta.wikimedia.org/wiki/Schema:Print */ -( function ( $, track, config, user, mwExperiments ) { +( function ( $, track, trackSubscribe, config, user, mwExperiments ) { /** * Log an event to the Schema:Print * @@ -68,6 +68,24 @@ } /** + * Log actions from Minerva download icon actions + */ + function setupMinervaLogging() { + trackSubscribe( 'minerva.downloadAsPDF', function ( data ) { + switch ( data.action ) { + case 'fetchImages': + logEvent( 'clickPrintableVersion' ); + break; + case 'buttonVisible': + logEvent( 'shownPrintButton' ); + break; + default: + // unknown state, do nothing + } + } ); + } + + /** * Log the event of printing. * Do it only once. */ @@ -103,6 +121,7 @@ $( function () { setupClickLogging(); setupPrintLogging(); + setupMinervaLogging(); } ); } -}( jQuery, mediaWiki.track, mediaWiki.config, mediaWiki.user, mediaWiki.experiments ) ); +}( jQuery, mediaWiki.track, mediaWiki.trackSubscribe, mediaWiki.config, mediaWiki.user, mediaWiki.experiments ) ); -- To view, visit https://gerrit.wikimedia.org/r/403214 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90b2487014c2fdcd18716628502672107c1a7c6f Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/WikimediaEvents Gerrit-Branch: master Gerrit-Owner: Pmiazga <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Pmiazga <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
