jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403765 )
Change subject: Fix incorrect mediawiki.trackSubscribe() call
......................................................................
Fix incorrect mediawiki.trackSubscribe() call
The previous patch had incorrect trackSubscribe call.
Also add the new schema revision id
Bug: T181297
Change-Id: I11f9b42b7bc093c4d767c81876add2d1017df79f
---
M extension.json
M modules/all/ext.wikimediaEvents.print.js
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/extension.json b/extension.json
index d800aa4..e3a35e1 100644
--- a/extension.json
+++ b/extension.json
@@ -78,7 +78,7 @@
"schema.Print": {
"class": "ResourceLoaderSchemaModule",
"schema": "Print",
- "revision": 17199246
+ "revision": 17630514
},
"schema.ReadingDepth": {
"class": "ResourceLoaderSchemaModule",
diff --git a/modules/all/ext.wikimediaEvents.print.js
b/modules/all/ext.wikimediaEvents.print.js
index fb42944..112f399 100644
--- a/modules/all/ext.wikimediaEvents.print.js
+++ b/modules/all/ext.wikimediaEvents.print.js
@@ -71,7 +71,7 @@
* Log actions from Minerva download icon actions
*/
function setupMinervaLogging() {
- trackSubscribe( 'minerva.downloadAsPDF', function ( data ) {
+ trackSubscribe( 'minerva.downloadAsPDF', function ( topic, data
) {
switch ( data.action ) {
case 'fetchImages':
logEvent( 'clickPrintableVersion' );
--
To view, visit https://gerrit.wikimedia.org/r/403765
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11f9b42b7bc093c4d767c81876add2d1017df79f
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Pmiazga <pmia...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
