Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403834 )
Change subject: List new comment tables in ParserTestRunner
......................................................................
List new comment tables in ParserTestRunner
Running the parser tests while in the migration,
some tables are missing.
Bug: T182416
Change-Id: I1010f4a35e5bf4626e522629447e43c413a05668
---
M tests/parser/ParserTestRunner.php
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/34/403834/1
diff --git a/tests/parser/ParserTestRunner.php
b/tests/parser/ParserTestRunner.php
index e07d4a0..6cf1fca 100644
--- a/tests/parser/ParserTestRunner.php
+++ b/tests/parser/ParserTestRunner.php
@@ -1151,6 +1151,8 @@
* @return array
*/
private function listTables() {
+ global $wgCommentTableSchemaMigrationStage;
+
$tables = [ 'user', 'user_properties', 'user_former_groups',
'page', 'page_restrictions',
'protected_titles', 'revision', 'ip_changes', 'text',
'pagelinks', 'imagelinks',
'categorylinks', 'templatelinks', 'externallinks',
'langlinks', 'iwlinks',
@@ -1160,6 +1162,13 @@
'archive', 'user_groups', 'page_props', 'category'
];
+ if ( $wgCommentTableSchemaMigrationStage >=
MIGRATION_WRITE_BOTH ) {
+ // The new tables for comments are in use
+ $tables[] = 'comment';
+ $tables[] = 'revision_comment_temp';
+ $tables[] = 'image_comment_temp';
+ }
+
if ( in_array( $this->db->getType(), [ 'mysql', 'sqlite',
'oracle' ] ) ) {
array_push( $tables, 'searchindex' );
}
--
To view, visit https://gerrit.wikimedia.org/r/403834
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1010f4a35e5bf4626e522629447e43c413a05668
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
