jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/403633 )
Change subject: Remove deprecated ruby browser tests ...................................................................... Remove deprecated ruby browser tests As they got replaced in by nodejs selenium test in I17b04e365b3df2aba9ee14f26b75896288158a69 Bug: T180246 Depends-On: I9b9f9a1c7f32a86b61e7db35027393354462e28c Change-Id: I7cc93c30bbc499f9d389bc8c751a443b75a88655 --- D .rubocop.yml D .rubocop_todo.yml D Gemfile D Gemfile.lock D tests/browser/README.mediawiki D tests/browser/environments.yml D tests/browser/features/download_screen.feature D tests/browser/features/support/env.rb D tests/browser/features/support/hooks.rb D tests/browser/features/support/pages/download_screen_page.rb D tests/browser/features/support/pages/mainpage_page.rb D tests/browser/features/support/step_definitions/download_screen.rb D tests/browser/features/support/step_definitions/mainpage.rb 13 files changed, 0 insertions(+), 246 deletions(-) Approvals: Zfilipin: Looks good to me, approved jenkins-bot: Verified diff --git a/.rubocop.yml b/.rubocop.yml deleted file mode 100644 index 3c8a650..0000000 --- a/.rubocop.yml +++ /dev/null @@ -1,22 +0,0 @@ -inherit_from: .rubocop_todo.yml - -AllCops: - StyleGuideCopsOnly: true - -Metrics/LineLength: - Max: 100 - -Metrics/MethodLength: - Enabled: false - -Style/Alias: - Enabled: false - -Style/SignalException: - Enabled: false - -Style/StringLiterals: - EnforcedStyle: single_quotes - -Style/TrivialAccessors: - ExactNameMatch: true diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml deleted file mode 100644 index 285a55f..0000000 --- a/.rubocop_todo.yml +++ /dev/null @@ -1,22 +0,0 @@ -# This configuration was generated by -# `rubocop --auto-gen-config` -# on 2017-12-06 13:21:11 +0000 using RuboCop version 0.48.1. -# The point is for the user to remove these configuration records -# one by one as the offenses are removed from the code base. -# Note that changes in the inspected code, or installation of new -# versions of RuboCop, may require this file to be generated again. - -# Offense count: 2 -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 119 - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: final_newline, final_blank_line -Style/TrailingBlankLines: - Exclude: - - 'tests/browser/features/support/env.rb' - - 'tests/browser/features/support/hooks.rb' diff --git a/Gemfile b/Gemfile deleted file mode 100644 index e011699..0000000 --- a/Gemfile +++ /dev/null @@ -1,6 +0,0 @@ -source 'https://rubygems.org' - -gem 'chunky_png', '~> 1.3.4' -gem 'mediawiki_selenium', '~> 1.7.0' -gem 'rake', '~> 10.4', '>= 10.4.2' -gem 'rubocop', '~> 0.51.0', require: false diff --git a/Gemfile.lock b/Gemfile.lock deleted file mode 100644 index 384059c..0000000 --- a/Gemfile.lock +++ /dev/null @@ -1,122 +0,0 @@ -GEM - remote: https://rubygems.org/ - specs: - ast (2.3.0) - builder (3.2.2) - childprocess (0.5.9) - ffi (~> 1.0, >= 1.0.11) - chunky_png (1.3.7) - cucumber (1.3.20) - builder (>= 2.1.2) - diff-lcs (>= 1.1.3) - gherkin (~> 2.12) - multi_json (>= 1.7.5, < 2.0) - multi_test (>= 0.1.2) - data_magic (0.22) - faker (>= 1.1.2) - yml_reader (>= 0.6) - diff-lcs (1.2.5) - domain_name (0.5.20161021) - unf (>= 0.0.5, < 1.0.0) - faker (1.6.6) - i18n (~> 0.5) - faraday (0.9.2) - multipart-post (>= 1.2, < 3) - faraday-cookie_jar (0.0.6) - faraday (>= 0.7.4) - http-cookie (~> 1.0.0) - faraday_middleware (0.10.0) - faraday (>= 0.7.4, < 0.10) - ffi (1.9.14) - ffi (1.9.14-x86-mingw32) - gherkin (2.12.2) - multi_json (~> 1.3) - gherkin (2.12.2-x86-mingw32) - multi_json (~> 1.3) - headless (2.3.1) - http-cookie (1.0.3) - domain_name (~> 0.5) - i18n (0.7.0) - json (1.8.3) - mediawiki_api (0.7.0) - faraday (~> 0.9, >= 0.9.0) - faraday-cookie_jar (~> 0.0, >= 0.0.6) - faraday_middleware (~> 0.10, >= 0.10.0) - mediawiki_selenium (1.7.2) - cucumber (~> 1.3, >= 1.3.20) - headless (~> 2.0, >= 2.1.0) - json (~> 1.8, >= 1.8.1) - mediawiki_api (~> 0.7, >= 0.7.0) - page-object (~> 1.0) - rest-client (~> 1.6, >= 1.6.7) - rspec-core (~> 2.14, >= 2.14.4) - rspec-expectations (~> 2.14, >= 2.14.4) - syntax (~> 1.2, >= 1.2.0) - thor (~> 0.19, >= 0.19.1) - mime-types (2.99.3) - multi_json (1.12.1) - multi_test (0.1.2) - multipart-post (2.0.0) - netrc (0.11.0) - page-object (1.2.0) - page_navigation (>= 0.9) - selenium-webdriver (>= 2.44.0) - watir-webdriver (>= 0.6.11) - page_navigation (0.10) - data_magic (>= 0.22) - parallel (1.12.0) - parser (2.4.0.2) - ast (~> 2.3) - powerpack (0.1.1) - rainbow (2.2.2) - rake - rake (10.5.0) - rest-client (1.8.0) - http-cookie (>= 1.0.2, < 2.0) - mime-types (>= 1.16, < 3.0) - netrc (~> 0.7) - rest-client (1.8.0-x86-mingw32) - ffi (~> 1.9) - http-cookie (>= 1.0.2, < 2.0) - mime-types (>= 1.16, < 3.0) - netrc (~> 0.7) - rspec-core (2.99.2) - rspec-expectations (2.99.2) - diff-lcs (>= 1.1.3, < 2.0) - rubocop (0.51.0) - parallel (~> 1.10) - parser (>= 2.3.3.1, < 3.0) - powerpack (~> 0.1) - rainbow (>= 2.2.2, < 3.0) - ruby-progressbar (~> 1.7) - unicode-display_width (~> 1.0, >= 1.0.1) - ruby-progressbar (1.9.0) - rubyzip (1.2.1) - selenium-webdriver (3.0.1) - childprocess (~> 0.5) - rubyzip (~> 1.0) - websocket (~> 1.0) - syntax (1.2.1) - thor (0.19.1) - unf (0.1.4) - unf_ext - unf_ext (0.0.7.2) - unf_ext (0.0.7.2-x86-mingw32) - unicode-display_width (1.3.0) - watir-webdriver (0.9.9) - selenium-webdriver (>= 2.46.2) - websocket (1.2.3) - yml_reader (0.7) - -PLATFORMS - ruby - x86-mingw32 - -DEPENDENCIES - chunky_png (~> 1.3.4) - mediawiki_selenium (~> 1.7.0) - rake (~> 10.4, >= 10.4.2) - rubocop (~> 0.51.0) - -BUNDLED WITH - 1.16.0 diff --git a/tests/browser/README.mediawiki b/tests/browser/README.mediawiki deleted file mode 100644 index 22092c4..0000000 --- a/tests/browser/README.mediawiki +++ /dev/null @@ -1,2 +0,0 @@ -For updated information about running browser tests for MediaWiki extension please see -https://www.mediawiki.org/wiki/Browser_testing/Running_tests diff --git a/tests/browser/environments.yml b/tests/browser/environments.yml deleted file mode 100644 index 4e84d0a..0000000 --- a/tests/browser/environments.yml +++ /dev/null @@ -1,30 +0,0 @@ -# Customize this configuration as necessary to provide defaults for various -# test environments. -# -# The set of defaults to use is determined by the MEDIAWIKI_ENVIRONMENT -# environment variable. -# -# export MEDIAWIKI_ENVIRONMENT=mw-vagrant-host -# bundle exec cucumber -# -# Additional variables set by the environment will override the corresponding -# defaults defined here. -# -# export MEDIAWIKI_ENVIRONMENT=mw-vagrant-host -# export MEDIAWIKI_USER=Selenium_user2 -# bundle exec cucumber -# -mw-vagrant-host: &default - mediawiki_url: http://127.0.0.1:8080/wiki/ - user_factory: true - -mw-vagrant-guest: - mediawiki_url: http://127.0.0.1/wiki/ - user_factory: true - -integration: - browser: chrome - user_factory: true - # mediawiki_url: THIS WILL BE SET BY JENKINS - -default: *default \ No newline at end of file diff --git a/tests/browser/features/download_screen.feature b/tests/browser/features/download_screen.feature deleted file mode 100644 index eef3013..0000000 --- a/tests/browser/features/download_screen.feature +++ /dev/null @@ -1,8 +0,0 @@ -@chrome @en.wikipedia.beta.wmflabs.org @firefox @integration -Feature: ElectronPdfService Download Screen - Background: - Given I am on the Main Page - - Scenario: Download screen is shown with correct data - When I click Download as PDF - Then I should see a print form with a download button diff --git a/tests/browser/features/support/env.rb b/tests/browser/features/support/env.rb deleted file mode 100644 index 3c896c2..0000000 --- a/tests/browser/features/support/env.rb +++ /dev/null @@ -1,3 +0,0 @@ -require 'mediawiki_selenium/cucumber' -require 'mediawiki_selenium/pages' -require 'mediawiki_selenium/step_definitions' \ No newline at end of file diff --git a/tests/browser/features/support/hooks.rb b/tests/browser/features/support/hooks.rb deleted file mode 100644 index 9e8e4cd..0000000 --- a/tests/browser/features/support/hooks.rb +++ /dev/null @@ -1,6 +0,0 @@ -# Needed for cucumber --dry-run -f stepdefs -require_relative 'env' - -Before('@skip') do |scenario| - scenario.skip_invoke! -end \ No newline at end of file diff --git a/tests/browser/features/support/pages/download_screen_page.rb b/tests/browser/features/support/pages/download_screen_page.rb deleted file mode 100644 index 06a0d9b..0000000 --- a/tests/browser/features/support/pages/download_screen_page.rb +++ /dev/null @@ -1,6 +0,0 @@ -class DownloadScreenPage - include PageObject - - hidden_field(:redirect_to_electron_action, css: '.mw-electronPdfService-selection-form [value=redirect-to-electron]') - button(:pdf_download_button, css: '.mw-electronPdfService-selection-form .oo-ui-buttonElement-button') -end diff --git a/tests/browser/features/support/pages/mainpage_page.rb b/tests/browser/features/support/pages/mainpage_page.rb deleted file mode 100644 index ee9f3f4..0000000 --- a/tests/browser/features/support/pages/mainpage_page.rb +++ /dev/null @@ -1,7 +0,0 @@ -class MainPage - include PageObject - - li(:download_as_pdf, css: '#coll-download-as-rl') - - page_url 'Main_Page' -end diff --git a/tests/browser/features/support/step_definitions/download_screen.rb b/tests/browser/features/support/step_definitions/download_screen.rb deleted file mode 100644 index 2641da1..0000000 --- a/tests/browser/features/support/step_definitions/download_screen.rb +++ /dev/null @@ -1,5 +0,0 @@ -Then(/^I should see a print form with a download button$/) do - on(DownloadScreenPage) do |page| - expect(page.pdf_download_button_element).to be_visible - end -end diff --git a/tests/browser/features/support/step_definitions/mainpage.rb b/tests/browser/features/support/step_definitions/mainpage.rb deleted file mode 100644 index 7eb84a2..0000000 --- a/tests/browser/features/support/step_definitions/mainpage.rb +++ /dev/null @@ -1,7 +0,0 @@ -Given(/^I am on the Main Page$/) do - visit(MainPage) -end - -When(/^I click Download as PDF$/) do - on(MainPage).download_as_pdf_element.when_visible.click -end -- To view, visit https://gerrit.wikimedia.org/r/403633 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cc93c30bbc499f9d389bc8c751a443b75a88655 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/ElectronPdfService Gerrit-Branch: master Gerrit-Owner: WMDE-Fisch <christoph.jau...@wikimedia.de> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Andrew-WMDE <andrew.kos...@wikimedia.de> Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
