jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/401731 )
Change subject: Improve type safety in parseItemIdParameter()
......................................................................
Improve type safety in parseItemIdParameter()
Change-Id: I027a2ad16a74c8b786acaa5abcad83b8e95a3678
---
M src/ConstraintCheck/Helper/ConstraintParameterParser.php
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Lucas Werkmeister (WMDE): Looks good to me, approved
jenkins-bot: Verified
Thiemo Kreuz (WMDE): Looks good to me, but someone else must approve
diff --git a/src/ConstraintCheck/Helper/ConstraintParameterParser.php
b/src/ConstraintCheck/Helper/ConstraintParameterParser.php
index 2177456..b84d6c7 100644
--- a/src/ConstraintCheck/Helper/ConstraintParameterParser.php
+++ b/src/ConstraintCheck/Helper/ConstraintParameterParser.php
@@ -259,16 +259,17 @@
}
private function parseItemIdParameter( PropertyValueSnak $snak,
$parameterId ) {
- if ( $snak->getDataValue() instanceof EntityIdValue &&
- $snak->getDataValue()->getEntityId() instanceof ItemId
+ $dataValue = $snak->getDataValue();
+ if ( $dataValue instanceof EntityIdValue &&
+ $dataValue->getEntityId() instanceof ItemId
) {
- return ItemIdSnakValue::fromItemId(
$snak->getDataValue()->getEntityId() );
+ return ItemIdSnakValue::fromItemId(
$dataValue->getEntityId() );
} else {
throw new ConstraintParameterException(
wfMessage(
'wbqc-violation-message-parameter-item' )
->rawParams(
$this->constraintParameterRenderer->formatPropertyId( $parameterId,
Role::CONSTRAINT_PARAMETER_PROPERTY ),
-
$this->constraintParameterRenderer->formatDataValue( $snak->getDataValue(),
Role::CONSTRAINT_PARAMETER_VALUE )
+
$this->constraintParameterRenderer->formatDataValue( $dataValue,
Role::CONSTRAINT_PARAMETER_VALUE )
)
->escaped()
);
--
To view, visit https://gerrit.wikimedia.org/r/401731
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I027a2ad16a74c8b786acaa5abcad83b8e95a3678
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Kreuz (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
