jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/322506 )

Change subject: Ignore non-items inside query results
......................................................................


Ignore non-items inside query results

Make use of new classmethod WikibasePage.is_valid_id().

Bug: T138364
Change-Id: I08ecc9cf24a26b17dd5f69abd0d75466f78715e8
---
M pywikibot/pagegenerators.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Multichill: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index 3db16a7..efe2a3c 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -2741,7 +2741,8 @@
     data = query_object.get_items(query,
                                   item_name=item_name,
                                   result_type=result_type)
-    items_pages = (pywikibot.ItemPage(repo, item) for item in data)
+    items_pages = (pywikibot.ItemPage(repo, item) for item in data
+                   if pywikibot.ItemPage.is_valid_id(item))
     if isinstance(site, pywikibot.site.DataSite):
         return items_pages
 

-- 
To view, visit https://gerrit.wikimedia.org/r/322506
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I08ecc9cf24a26b17dd5f69abd0d75466f78715e8
Gerrit-PatchSet: 5
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek <matejsuchane...@gmail.com>
Gerrit-Reviewer: Dalba <dalba.w...@gmail.com>
Gerrit-Reviewer: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: Lokal Profil <lokal.pro...@gmail.com>
Gerrit-Reviewer: Magul <tomasz.magul...@gmail.com>
Gerrit-Reviewer: Matěj Suchánek <matejsuchane...@gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.w...@gmail.com>
Gerrit-Reviewer: Multichill <maar...@mdammers.nl>
Gerrit-Reviewer: Xqt <i...@gno.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to