jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403952 )
Change subject: Fix persistence of on-this-day content on screen rotation.
......................................................................
Fix persistence of on-this-day content on screen rotation.
This patch mitigates data loss in the OnThisDay fragment by maintaining
the activity instance across configuration changes.
I've also changed the usage of RelativeLayout to ConstraintLayout, since
the former was having a rendering issue upon screen rotation.
Bug: T184649
Change-Id: I843ab049ef155e85afde15bab44bee7e5662c08d
---
M app/src/main/AndroidManifest.xml
M app/src/main/res/layout/view_on_this_day_event.xml
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Sharvaniharan: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index c4979b4..5e44511 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -228,7 +228,8 @@
android:name=".feed.mostread.MostReadArticlesActivity"
android:theme="@style/AppTheme.ActionBar"/>
- <activity android:name=".feed.onthisday.OnThisDayActivity" />
+ <activity android:name=".feed.onthisday.OnThisDayActivity"
+ android:configChanges="orientation|screenSize"/>
<activity android:name=".feed.configure.ConfigureActivity"
android:label="@string/feed_configure_activity_title"
diff --git a/app/src/main/res/layout/view_on_this_day_event.xml
b/app/src/main/res/layout/view_on_this_day_event.xml
index 41bc11a..6430cc8 100644
--- a/app/src/main/res/layout/view_on_this_day_event.xml
+++ b/app/src/main/res/layout/view_on_this_day_event.xml
@@ -16,7 +16,7 @@
android:layout_width="1dp"
android:layout_height="20dp" />
- <RelativeLayout
+ <android.support.constraint.ConstraintLayout
android:id="@+id/years_text_container"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
@@ -48,7 +48,7 @@
android:textSize="12sp"
android:maxLines="1"
tools:text="123 years ago" />
- </RelativeLayout>
+ </android.support.constraint.ConstraintLayout>
<LinearLayout
android:id="@+id/year_layout"
--
To view, visit https://gerrit.wikimedia.org/r/403952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I843ab049ef155e85afde15bab44bee7e5662c08d
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Cooltey <[email protected]>
Gerrit-Reviewer: Sharvaniharan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
