[MediaWiki-commits] [Gerrit] marvin[master]: Update: favor rem to em and use CSS variables

[Niedzielski (Code Review)]

Niedzielski has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403975 )

Change subject: Update: favor rem to em and use CSS variables
......................................................................

Update: favor rem to em and use CSS variables

Replace em units with rems and clean up some hardcoded values.

Change-Id: I407ec38a840388d9b669722c7e133e2b0f6bb572
---
M src/common/components/content-section/content-section.css
M src/common/components/content/styles/images.css
M src/common/components/content/styles/tables.css
3 files changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/75/403975/1

diff --git a/src/common/components/content-section/content-section.css 
b/src/common/components/content-section/content-section.css
index 934e727..ce73b40 100644
--- a/src/common/components/content-section/content-section.css
+++ b/src/common/components/content-section/content-section.css
@@ -6,6 +6,6 @@
 
 .ContentSection-header {
   /* Add a bottom divider under each section header. */
-  border-bottom: 1px solid var(--wmui-color-base80);
+  border-bottom: var(--border-width-base) solid var(--wmui-color-base80);
   padding: var(--half-space);
 }
diff --git a/src/common/components/content/styles/images.css 
b/src/common/components/content/styles/images.css
index 48938fe..a53c995 100644
--- a/src/common/components/content/styles/images.css
+++ b/src/common/components/content/styles/images.css
@@ -49,7 +49,7 @@
 /* 
http://localhost:3000/wiki/Pablo_Picasso?oldid=804068218#Synthetic_cubism:_1912.E2.80.931919
 */
   .Content
   .gallerytext {
-  margin: 0.5em 0;
+  margin: 0.5rem 0;
   font-size: var(--font-size-caption);
   color: var(--wmui-color-base20);
 }
diff --git a/src/common/components/content/styles/tables.css 
b/src/common/components/content/styles/tables.css
index 78882eb..3026827 100644
--- a/src/common/components/content/styles/tables.css
+++ b/src/common/components/content/styles/tables.css
@@ -28,7 +28,7 @@
 
 .Content table th,
 .Content td {
-  padding: 0.2em 0.5em;
+  padding: 0.2rem 0.5rem;
   font-size: 80%;
 
   /* Keep cells wide enough to contain their contents. This resets the more
@@ -39,32 +39,32 @@
 
 .Content .infobox {
   background-color: var(--wmui-color-base90);
-  border: 1px solid var(--wmui-color-base80);
+  border: var(--border-width-base) solid var(--wmui-color-base80);
 
   /* http://localhost:3000/wiki/Wolverine?oldid=804085375 */
   width: auto !important;
-  max-width: 22em !important;
+  max-width: 22rem !important;
 }
 
 @media (min-width: var(--min-width-large)) {
   .Content .infobox {
     /* http://localhost:3000/wiki/Wolverine?oldid=804085375 */
     float: right;
-    margin: 0 0 1em 1em;
+    margin: 0 0 1rem 1rem;
   }
 }
 
 .Content .infobox caption {
   font-size: 125%;
   font-weight: var(--font-weight-semibold);
-  padding: 0.2em;
+  padding: 0.2rem;
 }
 
 .Content .infobox td,
 .Content .infobox th {
   /* http://localhost:3000/wiki/China?oldid=804850001 (under "Transcriptions") 
*/
   text-align: left;
-  border-top: 1px solid var(--wmui-color-base80);
+  border-top: var(--border-width-base) solid var(--wmui-color-base80);
 }
 
 .Content .infobox tr:first-child > td,

-- 
To view, visit https://gerrit.wikimedia.org/r/403975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I407ec38a840388d9b669722c7e133e2b0f6bb572
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits