Mholloway has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403981 )
Change subject: Hygiene: Fix POTD test
......................................................................
Hygiene: Fix POTD test
For some reason this test was changed at some point to request an
image that in fact has extmetadata, including ImageDescription. This
changes it back so it tests what it says it tests.
Change-Id: Ibe40bd56ac6f2cd371826a616ee185c1318360cd
---
M test/features/featured-image/pagecontent.js
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps
refs/changes/81/403981/1
diff --git a/test/features/featured-image/pagecontent.js
b/test/features/featured-image/pagecontent.js
index 4b7cfdd..e9ccecd 100644
--- a/test/features/featured-image/pagecontent.js
+++ b/test/features/featured-image/pagecontent.js
@@ -32,15 +32,15 @@
});
});
- it('featured image with no extmetadata should have expected properties',
() => {
- const uri =
`${server.config.uri}en.wikipedia.org/v1/media/image/featured/2016/05/06`;
+ it('description should be found for image with no extmetadata', () => {
+ const uri =
`${server.config.uri}en.wikipedia.org/v1/media/image/featured/2016/05/23`;
return preq.get({ uri })
.then((res) => {
assert.status(res, 200);
- assert.equal(res.body.title, 'File:Kazakhstan Altay 3.jpg');
- assert.equal(res.body.thumbnail.source,
'https://upload.wikimedia.org/wikipedia/commons/thumb/9/99/Kazakhstan_Altay_3.jpg/640px-Kazakhstan_Altay_3.jpg');
- assert.equal(res.body.image.source,
'https://upload.wikimedia.org/wikipedia/commons/9/99/Kazakhstan_Altay_3.jpg');
- assert.contains(res.body.description.text, 'Altay mountains');
+ assert.equal(res.body.title, 'File:Fra et romersk
osteria.jpg');
+ assert.equal(res.body.thumbnail.source,
'https://upload.wikimedia.org/wikipedia/commons/thumb/7/7a/Fra_et_romersk_osteria.jpg/640px-Fra_et_romersk_osteria.jpg');
+ assert.equal(res.body.image.source,
'https://upload.wikimedia.org/wikipedia/commons/7/7a/Fra_et_romersk_osteria.jpg');
+ assert.contains(res.body.description.text, 'Roman Osteria');
assert.equal(res.body.description.lang, 'en');
});
});
--
To view, visit https://gerrit.wikimedia.org/r/403981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe40bd56ac6f2cd371826a616ee185c1318360cd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
