Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403986 )
Change subject: Fix usage of string resource for "OK". ...................................................................... Fix usage of string resource for "OK". The resource "R.string.OK" should not be used, since this resource actually comes from Mapbox, and isn't really under our control. It's better to use Android's built-in resource "android.R.string.OK". Change-Id: I1231c25434491feb01b3b12993e0cfe54787f10f --- M app/src/main/java/org/wikipedia/activity/BaseActivity.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/86/403986/1 diff --git a/app/src/main/java/org/wikipedia/activity/BaseActivity.java b/app/src/main/java/org/wikipedia/activity/BaseActivity.java index a74d2ae..494f6e3 100644 --- a/app/src/main/java/org/wikipedia/activity/BaseActivity.java +++ b/app/src/main/java/org/wikipedia/activity/BaseActivity.java @@ -232,7 +232,7 @@ @Subscribe public void on(SplitLargeListsEvent event) { new AlertDialog.Builder(BaseActivity.this) .setMessage(R.string.split_reading_list_message) - .setPositiveButton(R.string.ok, null) + .setPositiveButton(android.R.string.ok, null) .show(); } } -- To view, visit https://gerrit.wikimedia.org/r/403986 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1231c25434491feb01b3b12993e0cfe54787f10f Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <dbr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits