Chad has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404044 )
Change subject: makerelease: Fix up return on all code paths, pylint complains
......................................................................
makerelease: Fix up return on all code paths, pylint complains
Change-Id: I65d743441ee29a4fc05347c9ba3d1092fb0b5eff
---
M make-release/makerelease.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/release
refs/changes/44/404044/1
diff --git a/make-release/makerelease.py b/make-release/makerelease.py
index 3e09433..0186724 100755
--- a/make-release/makerelease.py
+++ b/make-release/makerelease.py
@@ -408,15 +408,18 @@
if self.options.yes:
return True
+ result = False
while True:
print(question + ' [y/n] ')
response = sys.stdin.readline()
if response:
if response[0].lower() == 'y':
- return True
+ result = True
+ break
elif response[0].lower() == 'n':
- return False
+ break
print('Please type "y" for yes or "n" for no')
+ return result
def export(self, git_ref, export_dir, patches=None):
if patches:
--
To view, visit https://gerrit.wikimedia.org/r/404044
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65d743441ee29a4fc05347c9ba3d1092fb0b5eff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
