jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403542 )
Change subject: SpecialProtectedpages: Remove options not used by HTMLForm
......................................................................
SpecialProtectedpages: Remove options not used by HTMLForm
HTMLForm gets the selected value from the request. The values
specified in the form descriptor were never used. (You can specify a
default value, but that uses the 'default' key anyway.)
Change-Id: I095ee004cbe74470f33c72b391b22dd4395bff6e
---
M includes/specials/SpecialProtectedpages.php
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/includes/specials/SpecialProtectedpages.php
b/includes/specials/SpecialProtectedpages.php
index 2ef9eaf..ac34996 100644
--- a/includes/specials/SpecialProtectedpages.php
+++ b/includes/specials/SpecialProtectedpages.php
@@ -101,7 +101,6 @@
'name' => 'namespace',
'id' => 'namespace',
'cssclass' => 'namespaceselector',
- 'selected' => $namespace,
'all' => '',
'label' => $this->msg( 'namespace' )->text(),
],
@@ -112,21 +111,18 @@
'label' => $this->msg( 'protectedpages-indef'
)->text(),
'name' => 'indefonly',
'id' => 'indefonly',
- 'value' => $indefOnly
],
'cascadecheck' => [
'type' => 'check',
'label' => $this->msg( 'protectedpages-cascade'
)->text(),
'name' => 'cascadeonly',
'id' => 'cascadeonly',
- 'value' => $cascadeOnly
],
'redirectcheck' => [
'type' => 'check',
'label' => $this->msg(
'protectedpages-noredirect' )->text(),
'name' => 'noredirect',
'id' => 'noredirect',
- 'value' => $noRedirect,
],
'sizelimit' => [
'class' => 'HTMLSizeFilterField',
@@ -166,7 +162,6 @@
return [
'type' => 'select',
'options' => $options,
- 'value' => $pr_type,
'label' => $this->msg( 'restriction-type' )->text(),
'name' => $this->IdType,
'id' => $this->IdType,
@@ -200,7 +195,6 @@
return [
'type' => 'select',
'options' => $options,
- 'value' => $pr_level,
'label' => $this->msg( 'restriction-level' )->text(),
'name' => $this->IdLevel,
'id' => $this->IdLevel
--
To view, visit https://gerrit.wikimedia.org/r/403542
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I095ee004cbe74470f33c72b391b22dd4395bff6e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz DziewoĆski <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits