jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403949 )
Change subject: OOUI: Manually pull in fix from I99caad7b ahead of the release
cycle
......................................................................
OOUI: Manually pull in fix from I99caad7b ahead of the release cycle
The .map file will be wrong, but those aren't used outside of an
experimental branch yet, so it's not the end of the world.
Bug: T184665
Change-Id: I9ff1ed80496ec61b836de4221dd36cde6d4a71ac
---
M resources/lib/oojs-ui/oojs-ui-toolbars.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
Esanders: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/resources/lib/oojs-ui/oojs-ui-toolbars.js
b/resources/lib/oojs-ui/oojs-ui-toolbars.js
index 59d6474..1b57f09 100644
--- a/resources/lib/oojs-ui/oojs-ui-toolbars.js
+++ b/resources/lib/oojs-ui/oojs-ui-toolbars.js
@@ -1978,7 +1978,7 @@
this.$element.addClass( 'oo-ui-popupToolGroup-active
oo-ui-popupToolGroup-left' );
this.setFlags( { progressive: true } );
this.toggleClipping( true );
- if ( this.isClippedHorizontally() ||
this.isFloatableOutOfView() ) {
+ if ( this.isClippedHorizontally() ) {
// Anchoring to the left caused the popup to
clip, so anchor it to the right instead
this.toggleClipping( false );
this.$element
@@ -1986,7 +1986,7 @@
.addClass( 'oo-ui-popupToolGroup-right'
);
this.toggleClipping( true );
}
- if ( this.isClippedHorizontally() ||
this.isFloatableOutOfView() ) {
+ if ( this.isClippedHorizontally() ) {
// Anchoring to the right also caused the popup
to clip, so just make it fill the container
containerWidth =
this.$clippableScrollableContainer.width();
containerLeft =
this.$clippableScrollableContainer[ 0 ] === document.documentElement ?
--
To view, visit https://gerrit.wikimedia.org/r/403949
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ff1ed80496ec61b836de4221dd36cde6d4a71ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
