jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/403955 )
Change subject: Remove PHPDoc blocks that just repeat the method header ...................................................................... Remove PHPDoc blocks that just repeat the method header Such comments do not add any new information. Change-Id: Ib4e529310ef66d36b6909fff7d1b07afd53a3fe8 --- M src/DataModel/Lexeme.php M src/Rdf/LexemeRdfBuilder.php M tests/phpunit/composer/DataModel/Services/Diff/FormDifferPatcherTest.php 3 files changed, 1 insertion(+), 25 deletions(-) Approvals: WMDE-leszek: Looks good to me, approved jenkins-bot: Verified diff --git a/src/DataModel/Lexeme.php b/src/DataModel/Lexeme.php index 2b64c7d..cc173be 100644 --- a/src/DataModel/Lexeme.php +++ b/src/DataModel/Lexeme.php @@ -208,9 +208,6 @@ return $this->lemmas; } - /** - * @param TermList $lemmas - */ public function setLemmas( TermList $lemmas ) { $this->lemmas = $lemmas; } @@ -228,9 +225,6 @@ return $this->lexicalCategory; } - /** - * @param ItemId $lexicalCategory - */ public function setLexicalCategory( ItemId $lexicalCategory ) { $this->lexicalCategory = $lexicalCategory; } @@ -248,9 +242,6 @@ return $this->language; } - /** - * @param ItemId $language - */ public function setLanguage( ItemId $language ) { $this->language = $language; } diff --git a/src/Rdf/LexemeRdfBuilder.php b/src/Rdf/LexemeRdfBuilder.php index 476268e..bedb8c6 100644 --- a/src/Rdf/LexemeRdfBuilder.php +++ b/src/Rdf/LexemeRdfBuilder.php @@ -27,14 +27,7 @@ */ private $writer; - /** - * @param RdfVocabulary $vocabulary - * @param RdfWriter $writer - */ - public function __construct( - RdfVocabulary $vocabulary, - RdfWriter $writer - ) { + public function __construct( RdfVocabulary $vocabulary, RdfWriter $writer ) { $this->vocabulary = $vocabulary; $this->writer = $writer; } diff --git a/tests/phpunit/composer/DataModel/Services/Diff/FormDifferPatcherTest.php b/tests/phpunit/composer/DataModel/Services/Diff/FormDifferPatcherTest.php index a6aba3c..5d4939e 100644 --- a/tests/phpunit/composer/DataModel/Services/Diff/FormDifferPatcherTest.php +++ b/tests/phpunit/composer/DataModel/Services/Diff/FormDifferPatcherTest.php @@ -163,10 +163,6 @@ $this->assertEquals( [], $form1->getGrammaticalFeatures() ); } - /** - * @param ItemId $gf - * @param Form $form - */ private function assertHasGrammaticalFeature( ItemId $gf, Form $form ) { $this->assertContains( $gf, @@ -178,10 +174,6 @@ ); } - /** - * @param ItemId $gf - * @param Form $form - */ private function assertDoentHaveGrammaticalFeature( ItemId $gf, Form $form ) { $this->assertNotContains( $gf, -- To view, visit https://gerrit.wikimedia.org/r/403955 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4e529310ef66d36b6909fff7d1b07afd53a3fe8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseLexeme Gerrit-Branch: master Gerrit-Owner: Thiemo Kreuz (WMDE) <thiemo.kr...@wikimedia.de> Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits