jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403848 )
Change subject: wfMemcKey (deprecated in MW 1.30) -> makeKey() on a BagOStuff
instance
......................................................................
wfMemcKey (deprecated in MW 1.30) -> makeKey() on a BagOStuff instance
Change-Id: Ibe93d353a0aa63d3a4b638ef7cf73bea8866c571
---
M includes/Comment.class.php
M includes/parser/CommentsOfTheDay.class.php
M includes/parser/NumberOfComments.class.php
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
SamanthaNguyen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Comment.class.php b/includes/Comment.class.php
index 2e473a8..cc3d315 100644
--- a/includes/Comment.class.php
+++ b/includes/Comment.class.php
@@ -429,7 +429,7 @@
// update cache for comment list
// should perform better than deleting cache completely since
Votes happen more frequently
- $key = wfMemcKey( 'comment', 'pagethreadlist', $this->page->id
);
+ $key = $wgMemc->makeKey( 'comment', 'pagethreadlist',
$this->page->id );
$comments = $wgMemc->get( $key );
if ( $comments ) {
foreach ( $comments as &$comment ) {
diff --git a/includes/parser/CommentsOfTheDay.class.php
b/includes/parser/CommentsOfTheDay.class.php
index 9eecd12..ddc1d5a 100644
--- a/includes/parser/CommentsOfTheDay.class.php
+++ b/includes/parser/CommentsOfTheDay.class.php
@@ -45,7 +45,7 @@
global $wgMemc;
// Try memcached first
- $key = wfMemcKey( 'comments-of-the-day', 'standalone-hook-new'
);
+ $key = $wgMemc->makeKey( 'comments-of-the-day',
'standalone-hook-new' );
$data = $wgMemc->get( $key );
if ( $data ) { // success, got it from memcached!
diff --git a/includes/parser/NumberOfComments.class.php
b/includes/parser/NumberOfComments.class.php
index b34b454..9a2f43e 100644
--- a/includes/parser/NumberOfComments.class.php
+++ b/includes/parser/NumberOfComments.class.php
@@ -34,7 +34,7 @@
global $wgMemc;
if ( $magicWordId == 'NUMBEROFCOMMENTS' ) {
- $key = wfMemcKey( 'comments', 'magic-word' );
+ $key = $wgMemc->makeKey( 'comments', 'magic-word' );
$data = $wgMemc->get( $key );
if ( $data != '' ) {
// We have it in cache? Oh goody, let's just
use the cached value!
@@ -96,7 +96,7 @@
static function getNumberOfCommentsPage( $pageId ) {
global $wgMemc;
- $key = wfMemcKey( 'comments', 'numberofcommentspage', $pageId );
+ $key = $wgMemc->makeKey( 'comments', 'numberofcommentspage',
$pageId );
$cache = $wgMemc->get( $key );
if ( $cache ) {
--
To view, visit https://gerrit.wikimedia.org/r/403848
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe93d353a0aa63d3a4b638ef7cf73bea8866c571
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Comments
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <[email protected]>
Gerrit-Reviewer: SamanthaNguyen <[email protected]>
Gerrit-Reviewer: UltrasonicNXT <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
