jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404159 )
Change subject: tests.utils.DrySite.version: Return '999.999' ...................................................................... tests.utils.DrySite.version: Return '999.999' In pywikibot site.version is used to see if an API feature is implemented in that version or not. '999.999' is a big enough version to be greater than any foreseeable MW version. From the dry tests point of view it will seem like the most recent version of MediaWiki. Change-Id: Iaa4e4dc86a9e139f83d1962bb7f8fee6494c9f6c --- M tests/utils.py 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/tests/utils.py b/tests/utils.py index ebaea24..ea9d420 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -21,7 +21,6 @@ from collections import Mapping from types import ModuleType -from warnings import warn from pywikibot.tools import PY2 @@ -462,10 +461,8 @@ return self._userinfo def version(self): - """Dummy version, with warning to show the callers context.""" - warn('%r returning version 1.24; override if unsuitable.' - % self, DrySiteNote, stacklevel=2) - return '1.24' + """Return a big dummy version string.""" + return '999.999' def image_repository(self): """Return Site object for image repository e.g. commons.""" -- To view, visit https://gerrit.wikimedia.org/r/404159 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa4e4dc86a9e139f83d1962bb7f8fee6494c9f6c Gerrit-PatchSet: 4 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba <dalba.w...@gmail.com> Gerrit-Reviewer: Dalba <dalba.w...@gmail.com> Gerrit-Reviewer: John Vandenberg <jay...@gmail.com> Gerrit-Reviewer: Xqt <i...@gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits