Ema has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404282 )
Change subject: varnishslowlog: do not crash on empty respheader values
......................................................................
varnishslowlog: do not crash on empty respheader values
Similarly to 7a5c50f, RespHeader can also be empty. Do not crash if that
is the case.
Change-Id: I46a991b60ac6f4910a5fa85efeec362c1a4df06b
---
M modules/varnish/files/varnishslowlog.py
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Ema: Looks good to me, approved
jenkins-bot: Verified
Gilles: Looks good to me, but someone else must approve
diff --git a/modules/varnish/files/varnishslowlog.py
b/modules/varnish/files/varnishslowlog.py
index 4e5ad1d..0883267 100644
--- a/modules/varnish/files/varnishslowlog.py
+++ b/modules/varnish/files/varnishslowlog.py
@@ -151,7 +151,14 @@
elif tag == 'RespHeader':
splitagain = value.split(None, 1)
header_name = splitagain[0][:-1]
- header_value = splitagain[1]
+
+ if len(splitagain) == 2:
+ header_value = splitagain[1]
+ else:
+ # Similarly to ReqHeader above, RespHeader can also occasionaly
+ # have no associated value.
+ header_value = ''
+
self.tx['response-' + header_name] = header_value
def main(self):
--
To view, visit https://gerrit.wikimedia.org/r/404282
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46a991b60ac6f4910a5fa85efeec362c1a4df06b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ema <[email protected]>
Gerrit-Reviewer: Ema <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
