jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404242 )
Change subject: Hygiene: remove extraneous disambig code
......................................................................
Hygiene: remove extraneous disambig code
The disambig flag gets determined inside the mUtil.getSummaryType()
method anyways.
Change-Id: I8a747be6351a7d70acb77252dda5269291b56a83
---
M routes/mobile-sections.js
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Mholloway: Looks good to me, approved
diff --git a/routes/mobile-sections.js b/routes/mobile-sections.js
index f8ed15a..b34d9f7 100644
--- a/routes/mobile-sections.js
+++ b/routes/mobile-sections.js
@@ -365,9 +365,7 @@
siteinfo: mwapi.getSiteInfo(app, req)
}).then((response) => {
const title = Title.newFromText(req.params.title, response.siteinfo);
- const pageProps = response.pageData.meta &&
response.pageData.meta.pageprops;
- const disambig = pageProps && {}.hasOwnProperty.call(pageProps,
'disambiguation');
- const summary = mUtil.buildSummary(req.params.domain, title,
response.pageData, disambig);
+ const summary = mUtil.buildSummary(req.params.domain, title,
response.pageData);
res.status(summary.code);
if (summary.code === 200) {
delete summary.code;
--
To view, visit https://gerrit.wikimedia.org/r/404242
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a747be6351a7d70acb77252dda5269291b56a83
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND <[email protected]>
Gerrit-Reviewer: Fjalapeno <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Mhurd <[email protected]>
Gerrit-Reviewer: Ppchelko <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
