jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404248 )
Change subject: summary: inline 204 checks
......................................................................
summary: inline 204 checks
The three checks for when to return 204 are simple enough that we could
inline them.
Change-Id: I4dd52a63c3bc438066c9d715e955f526c3c79255
---
M lib/summary.js
1 file changed, 3 insertions(+), 7 deletions(-)
Approvals:
jenkins-bot: Verified
Mholloway: Looks good to me, approved
diff --git a/lib/summary.js b/lib/summary.js
index 37e5450..9549204 100644
--- a/lib/summary.js
+++ b/lib/summary.js
@@ -80,19 +80,15 @@
* @return {!Object} a summary 2.0 spec-compliant page summary object
*/
function buildSummary(domain, title, html, revTid, meta) {
- const isContentModelWikitext = meta.contentmodel === 'wikitext';
- const isWhiteListedNamespace = SUMMARY_NS_WHITELIST.includes(meta.ns);
- const isRedirect = meta.redirect;
-
- if (!isContentModelWikitext) {
+ if (!SUMMARY_NS_WHITELIST.includes(meta.ns)) {
return { code: 204 };
}
- if (!isWhiteListedNamespace) {
+ if (meta.redirect) {
return { code: 204 };
}
- if (isRedirect) {
+ if (meta.contentmodel !== 'wikitext') {
return { code: 204 };
}
--
To view, visit https://gerrit.wikimedia.org/r/404248
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4dd52a63c3bc438066c9d715e955f526c3c79255
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Fjalapeno <cfl...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Mhurd <mh...@wikimedia.org>
Gerrit-Reviewer: Ppchelko <ppche...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
