Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404322 )
Change subject: Add status parameter to gadget’s API requests ...................................................................... Add status parameter to gadget’s API requests Only with this parameter does the gadget benefit from server-side caching, otherwise it requests lots of results which we don’t cache and which therefore require a full constraint check. (Note: for the check of an individual statement, we don’t cache results either, but specifying the status at least reduces the response size.) Bug: T183927 Change-Id: I7457566fdf4181719473dfc84e3ff872b49b3d4b --- M modules/gadget.js 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints refs/changes/22/404322/1 diff --git a/modules/gadget.js b/modules/gadget.js index b368d6e..da4d542 100644 --- a/modules/gadget.js +++ b/modules/gadget.js @@ -1,7 +1,8 @@ ( function( mw, wb, $, OO ) { 'use strict'; - var entityId; + var entityId, + cachedStatuses = 'violation|warning|bad-parameters'; function buildPopup( $content, $container, icon, iconTitleMessageKey, flags /* = '' */ ) { var widget = new OO.ui.PopupButtonWidget( { @@ -311,7 +312,8 @@ format: 'json', formatversion: 2, uselang: lang, - id: entityId + id: entityId, + status: cachedStatuses } ).then( function( data ) { $( '.wikibase-statementgroupview .wikibase-statementview' ) .each( function () { addReportsToStatement( data.wbcheckconstraints[ entityId ], $( this ) ); } ); @@ -337,7 +339,8 @@ format: 'json', formatversion: 2, uselang: lang, - claimid: statementId + claimid: statementId, + status: cachedStatuses } ).then( function( data ) { var statementClass = 'wikibase-statement-' + statementId.replace( /\$/, '\\$$' ); $( '.wikibase-statementgroupview .wikibase-statementview.' + statementClass ) -- To view, visit https://gerrit.wikimedia.org/r/404322 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7457566fdf4181719473dfc84e3ff872b49b3d4b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints Gerrit-Branch: master Gerrit-Owner: Lucas Werkmeister (WMDE) <lucas.werkmeis...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits