Faidon Liambotis has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404459 )
Change subject: Don't create (or remove) /var/run/kafkatee anymore
......................................................................
Don't create (or remove) /var/run/kafkatee anymore
We don't use the pidfile by default anymore, so it's a no-op as far as
Debian packaging goes. Also, creating /var/run directories in packages
is wrong and not guaranteed to work anyway (because /(var/)run may be a
tmpfs, or regularly cleaned up).
Change-Id: I7b02fa161c9e9f49c9854d93bbc5c35c313cbbca
---
M debian/kafkatee.dirs
M debian/kafkatee.postinst
M debian/kafkatee.postrm
3 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/kafkatee
refs/changes/59/404459/1
diff --git a/debian/kafkatee.dirs b/debian/kafkatee.dirs
index 610d1cc..5b6e9fb 100644
--- a/debian/kafkatee.dirs
+++ b/debian/kafkatee.dirs
@@ -1,4 +1,3 @@
etc/kafkatee.d
var/cache/kafkatee
var/cache/kafkatee/offsets
-var/run/kafkatee
\ No newline at end of file
diff --git a/debian/kafkatee.postinst b/debian/kafkatee.postinst
index 1b3033d..345203c 100755
--- a/debian/kafkatee.postinst
+++ b/debian/kafkatee.postinst
@@ -20,9 +20,8 @@
kafkatee >/dev/null 2>/dev/null || :
fi
- # chown /var/cache/kafkatee and /var/run/kafkatee for writing
+ # chown /var/cache/kafkatee for writing
chown -R kafkatee:kafkatee /var/cache/kafkatee
- chown -R kafkatee:kafkatee /var/run/kafkatee
echo \
"NOTE: Default kafkatee config files have been installed at:
diff --git a/debian/kafkatee.postrm b/debian/kafkatee.postrm
index 49c1ce9..bce1e39 100755
--- a/debian/kafkatee.postrm
+++ b/debian/kafkatee.postrm
@@ -10,7 +10,6 @@
purge)
rm -f /var/log/kafkatee.log*
rm -rf /var/cache/kafkatee
- rm -rf /var/run/kafkatee
deluser --quiet --system kafkatee >/dev/null || true
deluser --quiet --group --system --only-if-empty --remove-home
kafkatee || true
--
To view, visit https://gerrit.wikimedia.org/r/404459
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b02fa161c9e9f49c9854d93bbc5c35c313cbbca
Gerrit-PatchSet: 1
Gerrit-Project: analytics/kafkatee
Gerrit-Branch: master
Gerrit-Owner: Faidon Liambotis <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
