VolkerE has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404633 )
Change subject: Use “OOUI” as unified name for code comments ...................................................................... Use “OOUI” as unified name for code comments Bug: T182360 Change-Id: Ie2755724b3d9b826f4d5a7199213d410beb726a1 --- M modules/entrypoint/styles/ext.cx.contributions.less M modules/source/ext.cx.SelectedSourcePage.js M modules/tools/mw.cx.tools.TranslationTool.js M modules/tools/styles/ext.cx.tools.template.editor.less M modules/widgets/callout/ext.cx.callout.css M specials/SpecialContentTranslation.php 6 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation refs/changes/33/404633/1 diff --git a/modules/entrypoint/styles/ext.cx.contributions.less b/modules/entrypoint/styles/ext.cx.contributions.less index ee9e86a..b7748fd 100644 --- a/modules/entrypoint/styles/ext.cx.contributions.less +++ b/modules/entrypoint/styles/ext.cx.contributions.less @@ -15,7 +15,7 @@ height: 0; border-top: 21px solid @color-primary; border-left: 22px solid transparent; - z-index: 3; // oojs button has z-index 2 on hover + z-index: 3; // OOUI button has z-index 2 on hover } &:after { diff --git a/modules/source/ext.cx.SelectedSourcePage.js b/modules/source/ext.cx.SelectedSourcePage.js index e49251a..e9f6803 100644 --- a/modules/source/ext.cx.SelectedSourcePage.js +++ b/modules/source/ext.cx.SelectedSourcePage.js @@ -157,8 +157,8 @@ this.languageFilter.fillSourceLanguages( null, true ); this.languageFilter.fillTargetLanguages( null, true ); - $( 'html' ).click(); // Not sure why click doesn't pass through OOJS button to html element - // where listener is closing the ULS on outside clicks. Maybe some OOjs UI change? + $( 'html' ).click(); // Not sure why click doesn't pass through OOUI button to HTML element + // where listener is closing the ULS on outside clicks. Maybe some OOUI change? if ( this.onDiscard ) { this.onDiscard(); @@ -228,7 +228,7 @@ * @cfg {string} targetLanguage Target language code * @cfg {Object} [params] Parameters used for API call to get page info * @cfg {string} [imageUrl] URL for selected source page image - * @cfg {string} [imageIcon] OOjs UI class of selected page placeholder icon + * @cfg {string} [imageIcon] OOUI class of selected page placeholder icon * @cfg {Number} [numOfLanguages] Number of different language versions for selected source page */ mw.cx.SelectedSourcePage.prototype.setSelectedSourcePageData = function ( pageTitle, href, config ) { diff --git a/modules/tools/mw.cx.tools.TranslationTool.js b/modules/tools/mw.cx.tools.TranslationTool.js index 8d532d0..46e3f94 100644 --- a/modules/tools/mw.cx.tools.TranslationTool.js +++ b/modules/tools/mw.cx.tools.TranslationTool.js @@ -67,7 +67,7 @@ /** * Get all possible actions with this tool widget * @method - * @return {OO.ui.Element[]} Array of OOJS UI Elements + * @return {OO.ui.Element[]} Array of OOUI Elements */ mw.cx.tools.TranslationTool.prototype.getActions = function () { return []; diff --git a/modules/tools/styles/ext.cx.tools.template.editor.less b/modules/tools/styles/ext.cx.tools.template.editor.less index 9c67f18..acdeb13 100644 --- a/modules/tools/styles/ext.cx.tools.template.editor.less +++ b/modules/tools/styles/ext.cx.tools.template.editor.less @@ -104,7 +104,7 @@ .cx-template-editor-target-container { .cx-template-editor-param-selector { - // OOJS UI resets + // OOUI resets .oo-ui-dropdownWidget-handle { border: 0; background-color: @white; diff --git a/modules/widgets/callout/ext.cx.callout.css b/modules/widgets/callout/ext.cx.callout.css index d45b731..0ba69b0 100644 --- a/modules/widgets/callout/ext.cx.callout.css +++ b/modules/widgets/callout/ext.cx.callout.css @@ -1,4 +1,4 @@ -.cx-callout { /* styling accordingly to OOjs UI's `popupWidget-popup` */ +.cx-callout { /* styling accordingly to OOUI's `popupWidget-popup` */ background: #fff; color: #222; position: absolute; diff --git a/specials/SpecialContentTranslation.php b/specials/SpecialContentTranslation.php index 567334c..ac8e275 100644 --- a/specials/SpecialContentTranslation.php +++ b/specials/SpecialContentTranslation.php @@ -147,7 +147,7 @@ $out->addModuleStyles( 'mw.cx.ui.Header.skin' ); $initModule = 'mw.cx.init.legacy'; - // If request has param to use CX oojs based version, change init module. + // If request has param to use CX OOjs based version, change init module. if ( (int)$request->getVal( 'version' ) === 2 || (int)$wgContentTranslationVersion === 2 ) { $initModule = 'mw.cx.init'; } -- To view, visit https://gerrit.wikimedia.org/r/404633 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie2755724b3d9b826f4d5a7199213d410beb726a1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: VolkerE <volke...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits