Robert Vogel has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404678 )
Change subject: TitleCombo.js: Added redlink visualization ...................................................................... TitleCombo.js: Added redlink visualization Improved styling for the TitleCombo for better UX. NEEDS CHERRY-PICK TO REL1_27 and REL1_27_dev Change-Id: I2ff6a8558343642ad5a2047c3677b322b2aee404 --- M resources/bluespice.extjs/BS/form/field/TitleCombo.js M resources/bluespice.extjs/bluespice.extjs.overrides.less 2 files changed, 28 insertions(+), 3 deletions(-) Approvals: Robert Vogel: Verified; Looks good to me, approved diff --git a/resources/bluespice.extjs/BS/form/field/TitleCombo.js b/resources/bluespice.extjs/BS/form/field/TitleCombo.js index 457d452..64b003b 100644 --- a/resources/bluespice.extjs/BS/form/field/TitleCombo.js +++ b/resources/bluespice.extjs/BS/form/field/TitleCombo.js @@ -2,7 +2,7 @@ extend: 'Ext.ux.form.field.GridPicker', requires:[ 'BS.model.Title', 'BS.store.BSApi' ], - //This is necessary to make the ComboBox retrun a Model + //This is necessary to make the ComboBox return a Model //instance if input is less then 4 chars minChars: 1, @@ -30,7 +30,20 @@ columns: [{ dataIndex: 'displayText', flex: 1 - }] + }], + viewConfig: { + getRowClass: function(record, rowIndex, rowParams, store){ + var cssClass = 'bs-model-title-type-namespace'; + if( record.get( 'type' ) === 'namespace' ) { + return cssClass; + } + cssClass = 'bs-model-title-type-title'; + if( record.get( 'page_id' ) === 0 ) { + cssClass += ' new'; + } + return cssClass; + } + } }, excludeIds: [], diff --git a/resources/bluespice.extjs/bluespice.extjs.overrides.less b/resources/bluespice.extjs/bluespice.extjs.overrides.less index 093e449..d010cb5 100644 --- a/resources/bluespice.extjs/bluespice.extjs.overrides.less +++ b/resources/bluespice.extjs/bluespice.extjs.overrides.less @@ -73,4 +73,16 @@ .bs-typeicon { margin-right: 0.5em; -} \ No newline at end of file +} + +.bs-model-title-type-namespace .x-grid-cell { + font-style: oblique; +} + +.bs-model-title-type-title .x-grid-cell { + color: #3e5389; //MediaWiki default +} + +.bs-model-title-type-title.new .x-grid-cell { + color: #ba0000; //MediaWiki default + } \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/404678 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ff6a8558343642ad5a2047c3677b322b2aee404 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation Gerrit-Branch: REL1_27_dev Gerrit-Owner: Mglaser <gla...@hallowelt.biz> Gerrit-Reviewer: Ljonka <l.verhovs...@gmail.com> Gerrit-Reviewer: Pwirth <wi...@hallowelt.biz> Gerrit-Reviewer: Robert Vogel <vo...@hallowelt.biz> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits