jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404476 )
Change subject: Remove useless select from SPARQL query
......................................................................
Remove useless select from SPARQL query
We don’t use ?entity, so there’s no need to include it in the SELECT.
Change-Id: Ie2063797d7d26eb570ba4d544d4ad555a72ae33f
---
M src/ConstraintCheck/Helper/SparqlHelper.php
M tests/phpunit/Helper/SparqlHelperTest.php
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ConstraintCheck/Helper/SparqlHelper.php
b/src/ConstraintCheck/Helper/SparqlHelper.php
index 3855258..42d98c9 100644
--- a/src/ConstraintCheck/Helper/SparqlHelper.php
+++ b/src/ConstraintCheck/Helper/SparqlHelper.php
@@ -237,7 +237,7 @@
}
$query = <<<EOF
-SELECT ?entity ?otherEntity WHERE {
+SELECT ?otherEntity WHERE {
BIND(wd:$eid AS ?entity)
BIND($value AS ?value)
?entity ?p ?statement.
diff --git a/tests/phpunit/Helper/SparqlHelperTest.php
b/tests/phpunit/Helper/SparqlHelperTest.php
index 5c34130..22f28c2 100644
--- a/tests/phpunit/Helper/SparqlHelperTest.php
+++ b/tests/phpunit/Helper/SparqlHelperTest.php
@@ -170,7 +170,7 @@
->getMock();
$query = <<<EOF
-SELECT ?entity ?otherEntity WHERE {
+SELECT ?otherEntity WHERE {
BIND(wd:Q10 AS ?entity)
BIND($sparqlValue AS ?value)
?entity ?p ?statement.
--
To view, visit https://gerrit.wikimedia.org/r/404476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2063797d7d26eb570ba4d544d4ad555a72ae33f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
