jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404684 )
Change subject: ApiQueryTags: Remove unused tgprop value
......................................................................
ApiQueryTags: Remove unused tgprop value
While a tgprop=name has been defined since the module was created, it
has never made any difference to the output. Let's just remove it.
Bug: T185058
Change-Id: If9d7597751a8bdb8e415d6f7bab741452a6fd753
---
M RELEASE-NOTES-1.31
M includes/api/ApiQueryTags.php
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Reedy: Looks good to me, approved
jenkins-bot: Verified
Anomie: Looks good to me, approved
diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index fca71a7..45d096d 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -65,7 +65,9 @@
* (T90902) Non-breaking space in header ID breaks anchor
=== Action API changes in 1.31 ===
-* …
+* (T185058) The 'name' value to tgprop for action=query&list=tags has been
+ removed. It has never made a difference in the output, the name was always
+ returned regardless.
=== Action API internal changes in 1.31 ===
* …
diff --git a/includes/api/ApiQueryTags.php b/includes/api/ApiQueryTags.php
index 1b154fa..b340b57 100644
--- a/includes/api/ApiQueryTags.php
+++ b/includes/api/ApiQueryTags.php
@@ -141,9 +141,8 @@
ApiBase::PARAM_MAX2 => ApiBase::LIMIT_BIG2
],
'prop' => [
- ApiBase::PARAM_DFLT => 'name',
+ ApiBase::PARAM_DFLT => '',
ApiBase::PARAM_TYPE => [
- 'name',
'displayname',
'description',
'hitcount',
--
To view, visit https://gerrit.wikimedia.org/r/404684
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9d7597751a8bdb8e415d6f7bab741452a6fd753
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: TTO <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
