jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404658 )
Change subject: Fix javascript error on UploadWizard page
......................................................................
Fix javascript error on UploadWizard page
Javascript error on UploadWizard page was halting execution
of js on the page, which caused the bug.
Bug: T184380
Change-Id: I603485550db18dd0459628b0525ef6b24bdd1ed1
---
M resources/details/uw.DescriptionsDetailsWidget.js
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/details/uw.DescriptionsDetailsWidget.js
b/resources/details/uw.DescriptionsDetailsWidget.js
index 294ba47..38c18a5 100644
--- a/resources/details/uw.DescriptionsDetailsWidget.js
+++ b/resources/details/uw.DescriptionsDetailsWidget.js
@@ -56,14 +56,11 @@
* @param {number} n Number of descriptions
*/
uw.DescriptionsDetailsWidget.prototype.addDescriptions = function ( n )
{
- var i, items = [];
+ var items = [];
while ( n-- ) {
items.push( new uw.DescriptionDetailsWidget() );
}
this.addItems( items );
- for ( i = 0; i < items.length; i++ ) {
- items[ i ].initialiseUls();
- }
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/404658
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I603485550db18dd0459628b0525ef6b24bdd1ed1
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Cparle <cpa...@wikimedia.org>
Gerrit-Reviewer: MarkTraceur <mholmqu...@wikimedia.org>
Gerrit-Reviewer: Matthias Mullie <mmul...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
