jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404666 )
Change subject: getSelectedItem() -> findSelectedItem()
......................................................................
getSelectedItem() -> findSelectedItem()
Change-Id: Idf90335d06800b690063c7b2a781e822f0ee7ba9
---
M modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
M modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
M modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
M modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
M modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
5 files changed, 11 insertions(+), 11 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
index 2c4fd10..b1a9db4 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
@@ -617,7 +617,7 @@
* Handle change event for this.modeDropdown
*/
ve.ui.MWGalleryDialog.prototype.onModeDropdownChange = function () {
- var mode = this.modeDropdown.getMenu().getSelectedItem().getData(),
+ var mode = this.modeDropdown.getMenu().findSelectedItem().getData(),
disabled = (
mode === 'packed' ||
mode === 'packed-overlay' ||
@@ -737,8 +737,8 @@
data.showFilename = this.showFilenameCheckbox.isSelected() ? 'yes' :
undefined;
data.classes = this.classesInput.getValue() || undefined;
data.styles = this.stylesInput.getValue() || undefined;
- if ( this.modeDropdown.getMenu().getSelectedItem() ) {
- data.mode =
this.modeDropdown.getMenu().getSelectedItem().getData();
+ if ( this.modeDropdown.getMenu().findSelectedItem() ) {
+ data.mode =
this.modeDropdown.getMenu().findSelectedItem().getData();
}
// Unset mode attribute if it is the same as the default
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
index d9b770e..c61fdb9 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
@@ -81,7 +81,7 @@
ve.ui.MWTransclusionDialog.prototype.onOutlineControlsMove = function ( places
) {
var part, promise,
parts = this.transclusionModel.getParts(),
- item = this.bookletLayout.getOutline().getSelectedItem();
+ item = this.bookletLayout.getOutline().findSelectedItem();
if ( item ) {
part = this.transclusionModel.getPartFromId( item.getData() );
@@ -98,7 +98,7 @@
*/
ve.ui.MWTransclusionDialog.prototype.onOutlineControlsRemove = function () {
var id, part, param,
- item = this.bookletLayout.getOutline().getSelectedItem();
+ item = this.bookletLayout.getOutline().findSelectedItem();
if ( item ) {
id = item.getData();
@@ -134,7 +134,7 @@
*/
ve.ui.MWTransclusionDialog.prototype.onAddParameterButtonClick = function () {
var part, param,
- item = this.bookletLayout.getOutline().getSelectedItem();
+ item = this.bookletLayout.getOutline().findSelectedItem();
if ( item ) {
part = this.transclusionModel.getPartFromId( item.getData() );
@@ -307,7 +307,7 @@
ve.ui.MWTransclusionDialog.prototype.addPart = function ( part ) {
var index, promise,
parts = this.transclusionModel.getParts(),
- item = this.bookletLayout.getOutline().getSelectedItem();
+ item = this.bookletLayout.getOutline().findSelectedItem();
if ( part ) {
// Insert after selected part, or at the end if nothing is
selected
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
b/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
index b3edcd7..bfe069f 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
@@ -253,7 +253,7 @@
// Indexing items
currentIndexingItem = this.getMetaItem( 'mwIndex' );
- newIndexingData = this.indexing.getField().getSelectedItem();
+ newIndexingData = this.indexing.getField().findSelectedItem();
// Alter the indexing option flag iff it's been touched & is actually
different
if ( this.indexingOptionTouched ) {
@@ -276,7 +276,7 @@
// New section edit link items
currentNewSectionEditLinkItem = this.getMetaItem( 'mwNewSectionEdit' );
- newNewSectionEditLinkData =
this.newEditSectionLink.getField().getSelectedItem();
+ newNewSectionEditLinkData =
this.newEditSectionLink.getField().findSelectedItem();
// Alter the new section edit option flag iff it's been touched & is
actually different
if ( this.newSectionEditLinkOptionTouched ) {
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
b/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
index 322ad7d..fe6c461 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
@@ -305,7 +305,7 @@
// Table of Contents items
currentTableOfContents = this.getMetaItem( 'mwTOC' );
- newTableOfContentsData =
this.tableOfContents.getField().getSelectedItem();
+ newTableOfContentsData =
this.tableOfContents.getField().findSelectedItem();
// Redirect items
currentRedirectTargetItem = this.getMetaItem( 'mwRedirect' );
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
index 0100102..2e53985 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
@@ -107,7 +107,7 @@
menu = this.addTemplateInput.getLookupMenu();
if ( menu.isVisible() ) {
- menu.chooseItem( menu.getSelectedItem() );
+ menu.chooseItem( menu.findSelectedItem() );
}
name = this.addTemplateInput.getTitle();
if ( !name ) {
--
To view, visit https://gerrit.wikimedia.org/r/404666
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf90335d06800b690063c7b2a781e822f0ee7ba9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
