jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404735 )
Change subject: tests: Quick fix for unit tests asserting the shape of OOUI ids
......................................................................
tests: Quick fix for unit tests asserting the shape of OOUI ids
Longer term, these tests probably shouldn't rely on this detail, but this
unbreaks the tests for now.
Change-Id: Id1a794249d9b5ee3ca6200cb661e37b319155696
---
M tests/phpunit/HTMLFeatureFieldTest.php
M tests/phpunit/NewHTMLCheckFieldTest.php
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/HTMLFeatureFieldTest.php
b/tests/phpunit/HTMLFeatureFieldTest.php
index bbbf8c8..3266e7f 100644
--- a/tests/phpunit/HTMLFeatureFieldTest.php
+++ b/tests/phpunit/HTMLFeatureFieldTest.php
@@ -49,11 +49,11 @@
],
[
'pattern' => "#<input type='checkbox'
tabindex='0' aria-disabled='false' " .
- "name='wpblahblahblah' value='1'
id='ooui-\d+' class='oo-ui-inputWidget-input' />#",
+ "name='wpblahblahblah' value='1'
id='ooui-php-\d+' class='oo-ui-inputWidget-input' />#",
'message' => 'Styled checkbox input not found.',
],
[
- 'pattern' => "#<label for='ooui-\d+'
class='oo-ui-labelElement-label'>" .
+ 'pattern' => "#<label for='ooui-php-\d+'
class='oo-ui-labelElement-label'>" .
"blah blah blah</label>#",
'message' => 'Checkbox label not found.',
],
diff --git a/tests/phpunit/NewHTMLCheckFieldTest.php
b/tests/phpunit/NewHTMLCheckFieldTest.php
index f0671de..0f07b15 100644
--- a/tests/phpunit/NewHTMLCheckFieldTest.php
+++ b/tests/phpunit/NewHTMLCheckFieldTest.php
@@ -47,12 +47,12 @@
);
$this->assertRegExp(
"#<input type='checkbox' tabindex='0'
aria-disabled='false' name='wpblahblahblah' " .
- "value='1' checked='checked' id='ooui-\d+'
class='oo-ui-inputWidget-input' />#",
+ "value='1' checked='checked' id='ooui-php-\d+'
class='oo-ui-inputWidget-input' />#",
$html,
'Styled input not found.'
);
$this->assertRegExp(
- "#<label for='ooui-\d+'
class='oo-ui-labelElement-label'>blah blah blah</label>#",
+ "#<label for='ooui-php-\d+'
class='oo-ui-labelElement-label'>blah blah blah</label>#",
$html,
'Checkbox label not found.'
);
--
To view, visit https://gerrit.wikimedia.org/r/404735
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1a794249d9b5ee3ca6200cb661e37b319155696
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BetaFeatures
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
