jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/402894 )
Change subject: Add support for the "(page does not exist)" tooltip
......................................................................
Add support for the "(page does not exist)" tooltip
Depends on change Ia76dd6db363f6add5efb8955be9e23a1f8e8476f
in MediaWiki, which adds support for the 'exists' option.
(This change doesn't do anything on older versions.)
Also change the check from Title::isKnown() to Title::exists().
This is consistent with how we decide whether to link to action=edit
above, and the user sandbox is never "always known" anyway.
Change-Id: I4805916fb7f3b22eb5ad0e6971bccc238f17ea68
---
M SandboxLinkHooks.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Albert221: Looks good to me, but someone else must approve
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/SandboxLinkHooks.php b/SandboxLinkHooks.php
index 295c818..c1c9583 100644
--- a/SandboxLinkHooks.php
+++ b/SandboxLinkHooks.php
@@ -63,7 +63,8 @@
'id' => 'pt-sandbox',
'text' => $skin->msg( 'sandboxlink-portlet-label'
)->text(),
'href' => $href,
- 'class' => $title->isKnown() ? false : 'new',
+ 'class' => $title->exists() ? false : 'new',
+ 'exists' => $title->exists(),
'active' => $title->equals( $currentTitle ),
];
}
--
To view, visit https://gerrit.wikimedia.org/r/402894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4805916fb7f3b22eb5ad0e6971bccc238f17ea68
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SandboxLink
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Albert221 <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
