jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404603 )
Change subject: Summaries should not contain coordinates
......................................................................
Summaries should not contain coordinates
Bug: T185050
Change-Id: Idcb882eeabad8c63c18cf0e94a25ca799899445d
---
M lib/summary.js
M test/lib/summary/summary.test.js
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
Mholloway: Looks good to me, but someone else must approve
diff --git a/lib/summary.js b/lib/summary.js
index 62c57ce..d2325c7 100644
--- a/lib/summary.js
+++ b/lib/summary.js
@@ -92,6 +92,9 @@
return EMPTY_EXTRACTS;
} else {
const leadSectionDoc = parsoidSections.justLeadSection(doc);
+ // Apply before lead introduction extract to avoid
+ // removed content being in summary
+ transforms.stripUnneededMarkup(leadSectionDoc);
const intro = transforms.extractLeadIntroduction(leadSectionDoc);
if (intro.length) {
return transforms.summarize(intro);
@@ -146,6 +149,7 @@
module.exports = {
buildSummary,
testing: {
+ buildExtracts,
getSummaryType
}
};
diff --git a/test/lib/summary/summary.test.js b/test/lib/summary/summary.test.js
index de56ba1..860421e 100644
--- a/test/lib/summary/summary.test.js
+++ b/test/lib/summary/summary.test.js
@@ -2,8 +2,17 @@
const assert = require('../../utils/assert.js');
const unit = require('../../../lib/summary').testing;
+const domino = require('domino');
describe('lib:summary', () => {
+ describe('buildExtracts', () => {
+ it('Applies ', () => {
+ const doc = domino.createDocument(`<p><span>
+ <span
id="coordinates"><a>Hello</a></span></span></p><p>2</p>`);
+ const extract = unit.buildExtracts(doc, false);
+ assert.deepEqual(extract.extract_html, '<p>2</p>', 'Unneeded
markup is stripped.');
+ });
+ });
describe('getSummaryType', () => {
it('identifies main page', () => {
assert.deepEqual(unit.getSummaryType({ "mainpage": true }),
'mainpage');
--
To view, visit https://gerrit.wikimedia.org/r/404603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcb882eeabad8c63c18cf0e94a25ca799899445d
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Fjalapeno <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Mhurd <[email protected]>
Gerrit-Reviewer: Ppchelko <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
