jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403870 )
Change subject: Tests for PopulateDatabase
......................................................................
Tests for PopulateDatabase
Bug: T184140
Change-Id: I6fec77e85e1cc45e10d855f8edcef2d3e891cf64
---
A tests/phpunit/maintenance/PopulateDatabaseTest.php
1 file changed, 179 insertions(+), 0 deletions(-)
Approvals:
Ladsgroup: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/maintenance/PopulateDatabaseTest.php
b/tests/phpunit/maintenance/PopulateDatabaseTest.php
new file mode 100644
index 0000000..402f331
--- /dev/null
+++ b/tests/phpunit/maintenance/PopulateDatabaseTest.php
@@ -0,0 +1,179 @@
+<?php
+
+namespace ORES\Tests\Maintenance;
+
+use ORES\Maintenance\PopulateDatabase;
+
+use ORES\Tests\MockOresServiceBuilder;
+use ORES\Tests\TestHelper;
+
+/**
+ * @group ORES
+ * @group Database
+ * @covers ORES\Maintenance\PopulateDatabase
+ */
+class PopulateDatabaseTest extends \MediaWikiTestCase {
+
+ public function setUp() {
+ parent::setUp();
+ $this->tablesUsed = [
+ 'ores_classification',
+ 'ores_model',
+ 'recentchanges',
+ ];
+
+ $this->maintenance = new PopulateDatabase();
+
+ TestHelper::clearOresTables();
+ TestHelper::insertModelData();
+ \wfGetDB( DB_MASTER )->delete( 'recentchanges', '*', __METHOD__
);
+
+ $this->setMwGlobals( [
+ 'wgOresModels' => [ 'damaging' => true ],
+ 'wgOresWikiId' => 'wiki',
+ 'wgOresExcludeBots' => true,
+ ] );
+ $mockOresService = MockOresServiceBuilder::getORESServiceMock(
$this );
+ $this->setService( 'ORESService', $mockOresService );
+ }
+
+ public function provideTestData() {
+ return [
+ // Populate a single score.
+ [
+ [
+ (object)[
+ 'oresc_rev' => '123',
+ 'oresc_class' => '1',
+ 'oresc_probability' => '0.32',
+ 'oresc_model' =>
(string)TestHelper::DAMAGING,
+ ]
+ ],
+ [
+ [ 'rc_this_oldid' => '123',
'rc_user_text' => 'TestUser' ]
+ ],
+ [],
+ [],
+ ],
+
+ // Populate two scores.
+ [
+ [
+ (object)[
+ 'oresc_rev' => '123',
+ 'oresc_class' => '1',
+ 'oresc_probability' => '0.32',
+ 'oresc_model' =>
(string)TestHelper::DAMAGING,
+ ], (object)[
+ 'oresc_rev' => '321',
+ 'oresc_class' => '1',
+ 'oresc_probability' => '0.12',
+ 'oresc_model' =>
(string)TestHelper::DAMAGING,
+ ]
+ ],
+ [
+ [ 'rc_this_oldid' => '123',
'rc_user_text' => 'TestUser' ],
+ [ 'rc_this_oldid' => '321',
'rc_user_text' => 'TestUser' ],
+ ],
+ [
+ 123 => [ 'damaging' => 0.32 ],
+ ],
+ [],
+ ],
+
+ // Only one of two scores will be populated, due to a
limit.
+ [
+ [
+ (object)[
+ 'oresc_rev' => '321',
+ 'oresc_class' => '1',
+ 'oresc_probability' => '0.12',
+ 'oresc_model' =>
(string)TestHelper::DAMAGING,
+ ]
+ ],
+ [
+ [ 'rc_this_oldid' => '123',
'rc_user_text' => 'TestUser' ],
+ [ 'rc_this_oldid' => '321',
'rc_user_text' => 'TestUser' ],
+ ],
+ [],
+ [
+ '--batch', '1',
+ '--number', '1',
+ ],
+ ],
+
+ // A bot edit will be excluded.
+ [
+ [
+ (object)[
+ 'oresc_rev' => '123',
+ 'oresc_class' => '1',
+ 'oresc_probability' => '0.32',
+ 'oresc_model' =>
(string)TestHelper::DAMAGING,
+ ]
+ ],
+ [
+ [ 'rc_this_oldid' => '123',
'rc_user_text' => 'TestUser', 'rc_bot' => '0' ],
+ [ 'rc_this_oldid' => '321',
'rc_user_text' => 'TestUser', 'rc_bot' => '1' ],
+ ],
+ [],
+ [],
+ ],
+
+ // Scores will be populated in two batches.
+ // TODO: Can we prove that batching happened?
+ [
+ [
+ (object)[
+ 'oresc_rev' => '123',
+ 'oresc_class' => '1',
+ 'oresc_probability' => '0.32',
+ 'oresc_model' =>
(string)TestHelper::DAMAGING,
+ ],
+ (object)[
+ 'oresc_rev' => '321',
+ 'oresc_class' => '1',
+ 'oresc_probability' => '0.12',
+ 'oresc_model' =>
(string)TestHelper::DAMAGING,
+ ]
+ ],
+ [
+ [ 'rc_this_oldid' => '123',
'rc_user_text' => 'TestUser' ],
+ [ 'rc_this_oldid' => '321',
'rc_user_text' => 'TestUser' ],
+ ],
+ [],
+ [
+ '--batch', '1',
+ ],
+ ],
+ ];
+ }
+
+ /**
+ * @dataProvider provideTestData
+ */
+ public function testPopulateDatabase( $expected, $rcContents,
$oresContents, $argv ) {
+ \wfGetDB( DB_MASTER )->insert( 'recentchanges', $rcContents,
__METHOD__ );
+
+ foreach ( $oresContents as $revId => $scores ) {
+ TestHelper::insertOresData( $revId, $scores );
+ }
+
+ // FIXME: Write a base maintenance test case that suppresses
output.
+ $argv = array_merge( $argv, [ '--quiet' ] );
+
+ $this->maintenance->loadWithArgv( $argv );
+ $this->maintenance->execute();
+
+ $scores = \wfGetDB( DB_REPLICA )->select(
+ [ 'ores_classification' ],
+ [ 'oresc_rev', 'oresc_class', 'oresc_probability',
'oresc_model' ],
+ null,
+ __METHOD__,
+ [ 'ORDER BY' => 'oresc_rev' ]
+ );
+
+ $this->assertEquals( $expected, iterator_to_array( $scores,
false ) );
+ }
+
+}
--
To view, visit https://gerrit.wikimedia.org/r/403870
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fec77e85e1cc45e10d855f8edcef2d3e891cf64
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
