jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404898 )
Change subject: Remove obsolete 'position' annotations from ResourceLoader module definitons ...................................................................... Remove obsolete 'position' annotations from ResourceLoader module definitons Defining the position of where the ResourceLoader module should be loaded has been obsolete since 1.29.0 and now load asynchronously. See: I6c21e3e47c23df33a04c42ce94bd4c1964599c7f Change-Id: I7360e259647c9024482374af455b4ec7d13ee883 --- M SocialProfile.php M SystemGifts/extension.json M UserActivity/extension.json M UserBoard/extension.json M UserGifts/extension.json M UserProfile/UserProfile.php M UserRelationship/extension.json M UserStats/extension.json M UserWelcome/extension.json 9 files changed, 24 insertions(+), 52 deletions(-) Approvals: Jack Phoenix: Looks good to me, approved jenkins-bot: Verified diff --git a/SocialProfile.php b/SocialProfile.php index 7bd5de6..405f2e8 100644 --- a/SocialProfile.php +++ b/SocialProfile.php @@ -118,14 +118,12 @@ // General $wgResourceModules['ext.socialprofile.clearfix'] = array( 'styles' => 'clearfix.css', - 'position' => 'top', 'localBasePath' => __DIR__ . '/shared', 'remoteExtPath' => 'SocialProfile/shared', ); $wgResourceModules['ext.socialprofile.responsive'] = array( 'styles' => 'responsive.less', - 'position' => 'top', 'localBasePath' => __DIR__ . '/shared', 'remoteExtPath' => 'SocialProfile/shared', ); @@ -135,14 +133,12 @@ // @see https://phabricator.wikimedia.org/T100025 $wgResourceModules['ext.socialprofile.flash'] = array( 'scripts' => 'flash.js', - 'position' => 'bottom', 'localBasePath' => __DIR__ . '/shared', 'remoteExtPath' => 'SocialProfile/shared', ); $wgResourceModules['ext.socialprofile.LightBox'] = array( 'scripts' => 'LightBox.js', - 'position' => 'bottom', 'localBasePath' => __DIR__ . '/shared', 'remoteExtPath' => 'SocialProfile/shared', ); diff --git a/SystemGifts/extension.json b/SystemGifts/extension.json index 2e84d47..271cc90 100644 --- a/SystemGifts/extension.json +++ b/SystemGifts/extension.json @@ -60,32 +60,25 @@ }, "ResourceModules": { "ext.socialprofile.systemgifts.css": { - "styles": "SystemGift.css", - "position": "top" + "styles": "SystemGift.css" }, "ext.socialprofile.special.removemastersystemgift.css": { - "styles": "SpecialRemoveMasterSystemGift.css", - "position": "top" + "styles": "SpecialRemoveMasterSystemGift.css" }, "ext.socialprofile.special.systemgiftmanager.css": { - "styles": "SpecialSystemGiftManager.css", - "position": "top" + "styles": "SpecialSystemGiftManager.css" }, "ext.socialprofile.special.systemgiftmanagerlogo.css": { - "styles": "SpecialSystemGiftManagerLogo.css", - "position": "top" + "styles": "SpecialSystemGiftManagerLogo.css" }, "ext.socialprofile.special.topawards.css": { - "styles": "SpecialTopAwards.css", - "position": "top" + "styles": "SpecialTopAwards.css" }, "ext.socialprofile.special.viewsystemgift.css": { - "styles": "SpecialViewSystemGift.css", - "position": "top" + "styles": "SpecialViewSystemGift.css" }, "ext.socialprofile.special.viewsystemgifts.css": { - "styles": "SpecialViewSystemGifts.css", - "position": "top" + "styles": "SpecialViewSystemGifts.css" } }, "ResourceFileModulePaths": { diff --git a/UserActivity/extension.json b/UserActivity/extension.json index 2df8cfc..35736f1 100644 --- a/UserActivity/extension.json +++ b/UserActivity/extension.json @@ -29,8 +29,7 @@ }, "ResourceModules": { "ext.socialprofile.useractivity.css": { - "styles": "UserActivity.css", - "position": "top" + "styles": "UserActivity.css" } }, "ResourceFileModulePaths": { diff --git a/UserBoard/extension.json b/UserBoard/extension.json index fc922b9..0dbc920 100644 --- a/UserBoard/extension.json +++ b/UserBoard/extension.json @@ -50,12 +50,10 @@ ] }, "ext.socialprofile.userboard.css": { - "styles": "UserBoard.css", - "position": "top" + "styles": "UserBoard.css" }, "ext.socialprofile.userboard.boardblast.css": { - "styles": "BoardBlast.css", - "position": "top" + "styles": "BoardBlast.css" }, "ext.socialprofile.userboard.boardblast.js": { "scripts": "BoardBlast.js", diff --git a/UserGifts/extension.json b/UserGifts/extension.json index 58b8cfe..35e1e00 100644 --- a/UserGifts/extension.json +++ b/UserGifts/extension.json @@ -49,24 +49,19 @@ }, "ResourceModules": { "ext.socialprofile.usergifts.css": { - "styles": "UserGifts.css", - "position": "top" + "styles": "UserGifts.css" }, "ext.socialprofile.special.giftmanager.css": { - "styles": "SpecialGiftManager.css", - "position": "top" + "styles": "SpecialGiftManager.css" }, "ext.socialprofile.special.givegift.css": { - "styles": "SpecialGiveGift.css", - "position": "top" + "styles": "SpecialGiveGift.css" }, "ext.socialprofile.special.viewgift.css": { - "styles": "SpecialViewGift.css", - "position": "top" + "styles": "SpecialViewGift.css" }, "ext.socialprofile.special.viewgifts.css": { - "styles": "SpecialViewGifts.css", - "position": "top" + "styles": "SpecialViewGifts.css" }, "ext.socialprofile.usergifts.js": { "scripts": "UserGifts.js" diff --git a/UserProfile/UserProfile.php b/UserProfile/UserProfile.php index 17228ab..b6b9ffa 100644 --- a/UserProfile/UserProfile.php +++ b/UserProfile/UserProfile.php @@ -76,8 +76,7 @@ $wgResourceModules['ext.socialprofile.userprofile.css'] = array( 'styles' => 'UserProfile.css', 'localBasePath' => __DIR__, - 'remoteExtPath' => 'SocialProfile/UserProfile', - 'position' => 'top' + 'remoteExtPath' => 'SocialProfile/UserProfile' ); $wgResourceModules['ext.socialprofile.userprofile.js'] = array( @@ -93,37 +92,32 @@ 'scripts' => 'UpdateProfile.js', 'dependencies' => array( 'mediawiki.api', 'mediawiki.util', 'jquery.ui.datepicker' ), 'localBasePath' => __DIR__, - 'remoteExtPath' => 'SocialProfile/UserProfile', - 'position' => 'top' + 'remoteExtPath' => 'SocialProfile/UserProfile' ); // CSS for user avatars in page diffs $wgResourceModules['ext.socialprofile.userprofile.diff'] = array( 'styles' => 'AvatarsInDiffs.css', 'localBasePath' => __DIR__, - 'remoteExtPath' => 'SocialProfile/UserProfile', - 'position' => 'top' + 'remoteExtPath' => 'SocialProfile/UserProfile' ); $wgResourceModules['ext.socialprofile.userprofile.tabs.css'] = array( 'styles' => 'ProfileTabs.css', 'localBasePath' => __DIR__, - 'remoteExtPath' => 'SocialProfile/UserProfile', - 'position' => 'top' + 'remoteExtPath' => 'SocialProfile/UserProfile' ); $wgResourceModules['ext.socialprofile.special.uploadavatar.css'] = array( 'styles' => 'SpecialUploadAvatar.css', 'localBasePath' => __DIR__, - 'remoteExtPath' => 'SocialProfile/UserProfile', - 'position' => 'top' + 'remoteExtPath' => 'SocialProfile/UserProfile' ); $wgResourceModules['ext.socialprofile.special.updateprofile.css'] = array( 'styles' => 'SpecialUpdateProfile.css', 'localBasePath' => __DIR__, - 'remoteExtPath' => 'SocialProfile/UserProfile', - 'position' => 'top' + 'remoteExtPath' => 'SocialProfile/UserProfile' ); # Add new log types for profile edits and avatar uploads diff --git a/UserRelationship/extension.json b/UserRelationship/extension.json index 65af8b2..12822c9 100644 --- a/UserRelationship/extension.json +++ b/UserRelationship/extension.json @@ -42,8 +42,7 @@ }, "ResourceModules": { "ext.socialprofile.userrelationship.css": { - "styles": "UserRelationship.css", - "position": "top" + "styles": "UserRelationship.css" }, "ext.socialprofile.userrelationship.js": { "scripts": "UserRelationship.js", diff --git a/UserStats/extension.json b/UserStats/extension.json index c23b83d..a7002e6 100644 --- a/UserStats/extension.json +++ b/UserStats/extension.json @@ -69,8 +69,7 @@ }, "ResourceModules": { "ext.socialprofile.userstats.css": { - "styles": "TopList.css", - "position": "top" + "styles": "TopList.css" } }, "ResourceFileModulePaths": { diff --git a/UserWelcome/extension.json b/UserWelcome/extension.json index 61e25ec..b089420 100644 --- a/UserWelcome/extension.json +++ b/UserWelcome/extension.json @@ -21,8 +21,7 @@ }, "ResourceModules": { "ext.socialprofile.userwelcome.css": { - "styles": "UserWelcome.css", - "position": "top" + "styles": "UserWelcome.css" } }, "ResourceFileModulePaths": { -- To view, visit https://gerrit.wikimedia.org/r/404898 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7360e259647c9024482374af455b4ec7d13ee883 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SocialProfile Gerrit-Branch: master Gerrit-Owner: SamanthaNguyen <samanthanguyen1...@gmail.com> Gerrit-Reviewer: Jack Phoenix <ash...@uncyclomedia.co> Gerrit-Reviewer: Lewis Cawte <le...@lewiscawte.me> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits