jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404872 )
Change subject: [IMPR] Add isAnonymous() check in few User fcts
......................................................................
[IMPR] Add isAnonymous() check in few User fcts
This could safe up api calls
Follows 86917aeecf6e7a5ecce4d2f5a95665a028e94cb1
Bug: T183877
Change-Id: I66bce102fcf782a88182ac23cfa1ac8c23541366
---
M pywikibot/page.py
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/pywikibot/page.py b/pywikibot/page.py
index 767835d..9277f73 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -3241,6 +3241,8 @@
@rtype: pywikibot.Timestamp or None
"""
+ if self.isAnonymous():
+ return None
reg = self.getprops(force).get('registration')
if reg:
return pywikibot.Timestamp.fromISOformat(reg)
@@ -3278,7 +3280,7 @@
@rtype: bool
"""
- return 'emailable' in self.getprops(force)
+ return (not self.isAnonymous() and 'emailable' in self.getprops(force))
def groups(self, force=False):
"""
@@ -3301,6 +3303,8 @@
@return: return 'male', 'female', or 'unknown'
@rtype: str
"""
+ if self.isAnonymous():
+ return 'unknown'
return self.getprops(force).get('gender', 'unknown')
def rights(self, force=False):
--
To view, visit https://gerrit.wikimedia.org/r/404872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66bce102fcf782a88182ac23cfa1ac8c23541366
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Framawiki <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: Zoranzoki21 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
