jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404719 )
Change subject: Update eslint and stylelint ...................................................................... Update eslint and stylelint Change-Id: I650eb43d7f44ab8beead11eaf66911d40b4e094d --- M modules/ext.advancedSearch.css M modules/ext.advancedSearch.init.css M modules/ui/ext.advancedSearch.TemplateSearch.js M package.json 4 files changed, 9 insertions(+), 8 deletions(-) Approvals: Gabriel Birke: Looks good to me, approved Zfilipin: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/modules/ext.advancedSearch.css b/modules/ext.advancedSearch.css index d3f4a41..0d91f45 100644 --- a/modules/ext.advancedSearch.css +++ b/modules/ext.advancedSearch.css @@ -124,7 +124,7 @@ .mw-advancedSearch-namespace-selection { border-radius: 2px; border: solid 1px #a2a9b1; - background: rgb( 248, 249, 250 ); + background: #f8f9fa; box-sizing: border-box; margin-top: 0.3em; max-width: 50em; diff --git a/modules/ext.advancedSearch.init.css b/modules/ext.advancedSearch.init.css index df8c477..f007eda 100644 --- a/modules/ext.advancedSearch.init.css +++ b/modules/ext.advancedSearch.init.css @@ -1,4 +1,4 @@ -/* stylelint-disable-next-line selector-no-id */ +/* stylelint-disable-next-line selector-max-id */ .client-js #mw-searchoptions, .client-js .mw-search-profile-tabs { display: none; diff --git a/modules/ui/ext.advancedSearch.TemplateSearch.js b/modules/ui/ext.advancedSearch.TemplateSearch.js index 07cdd32..93580d6 100644 --- a/modules/ui/ext.advancedSearch.TemplateSearch.js +++ b/modules/ui/ext.advancedSearch.TemplateSearch.js @@ -147,7 +147,7 @@ /** * Implemented because OO.ui.mixin.LookupElement expects it. * - * @returns {boolean} + * @return {boolean} */ mw.libs.advancedSearch.ui.TemplateSearch.prototype.isReadOnly = function () { return false; diff --git a/package.json b/package.json index 8d0d533..7ecdc13 100644 --- a/package.json +++ b/package.json @@ -4,15 +4,16 @@ "test": "grunt test" }, "devDependencies": { - "eslint": "3.12.2", - "eslint-config-wikimedia": "0.4.0", + "eslint": "4.9.0", + "eslint-config-wikimedia": "0.5.0", "grunt": "1.0.1", "grunt-banana-checker": "0.6.0", - "grunt-eslint": "20.0.0", + "grunt-eslint": "20.1.0", "grunt-jsonlint": "1.1.0", - "grunt-stylelint": "0.7.0", + "grunt-stylelint": "0.9.0", "qunitjs": "^2.4.0", "sinon": "^1.17.3", - "stylelint-config-wikimedia": "0.4.1" + "stylelint": "8.2.0", + "stylelint-config-wikimedia": "0.4.2" } } -- To view, visit https://gerrit.wikimedia.org/r/404719 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I650eb43d7f44ab8beead11eaf66911d40b4e094d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/AdvancedSearch Gerrit-Branch: master Gerrit-Owner: WMDE-Fisch <christoph.jau...@wikimedia.de> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Andrew-WMDE <andrew.kos...@wikimedia.de> Gerrit-Reviewer: Gabriel Birke <gabriel.bi...@wikimedia.de> Gerrit-Reviewer: Pablo Grass (WMDE) <pablo.gr...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: Tonina Zhelyazkova <tonina.zhelyazk...@wikimedia.de> Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits