[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: [WIP] Reading List Sync :User education message for not logg...

[Sharvaniharan (Code Review)]

Sharvaniharan has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405020 )

Change subject: [WIP] Reading List Sync :User education message for not logged 
in users
......................................................................

[WIP] Reading List Sync :User education message for not logged in users

-Show reading lists sync on-boarding card to users who aren't logged in.
        -Dismisses on click of 'GOT IT'
        -Log in flow on click of 'LOG IN'
        -Displays sync education text.

todo: access the right image url

Bug: T183520
Change-Id: Ia60dec7cc7490d6bbf77978d785bef663072a758
---
M app/src/main/java/org/wikipedia/feed/onboarding/OnboardingClient.java
A 
app/src/main/java/org/wikipedia/feed/onboarding/ReadingListsSyncOnboardingCard.java
M app/src/main/res/values/preference_keys.xml
M app/src/main/res/values/strings.xml
4 files changed, 41 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/20/405020/1

diff --git 
a/app/src/main/java/org/wikipedia/feed/onboarding/OnboardingClient.java 
b/app/src/main/java/org/wikipedia/feed/onboarding/OnboardingClient.java
index 344e331..152d401 100644
--- a/app/src/main/java/org/wikipedia/feed/onboarding/OnboardingClient.java
+++ b/app/src/main/java/org/wikipedia/feed/onboarding/OnboardingClient.java
@@ -38,6 +38,17 @@
             cards.add(card);
         }
 
+        OnboardingCard syncCard = new ReadingListsSyncOnboardingCard(new 
Announcement(
+                "readingListssyncCard",
+                
context.getString(R.string.feed_reading_lists_sync_onboarding_text),
+                
"https://upload.wikimedia.org/wikipedia/commons/3/3b/Announcement_header_for_Explore_Feed_customization.png";,
+                new 
Announcement.Action(context.getString(R.string.menu_login), 
UriUtil.LOCAL_URL_LOGIN),
+                context.getString(R.string.onboarding_got_it)));
+
+        if (syncCard.shouldShow()) {
+            cards.add(syncCard);
+        }
+
         cb.success(cards);
     }
 
diff --git 
a/app/src/main/java/org/wikipedia/feed/onboarding/ReadingListsSyncOnboardingCard.java
 
b/app/src/main/java/org/wikipedia/feed/onboarding/ReadingListsSyncOnboardingCard.java
new file mode 100644
index 0000000..38ddf1a
--- /dev/null
+++ 
b/app/src/main/java/org/wikipedia/feed/onboarding/ReadingListsSyncOnboardingCard.java
@@ -0,0 +1,28 @@
+package org.wikipedia.feed.onboarding;
+
+
+import android.support.annotation.NonNull;
+
+import org.wikipedia.R;
+import org.wikipedia.auth.AccountUtil;
+import org.wikipedia.feed.announcement.Announcement;
+import org.wikipedia.feed.model.CardType;
+
+public class ReadingListsSyncOnboardingCard extends OnboardingCard {
+    public ReadingListsSyncOnboardingCard(@NonNull Announcement announcement) {
+        super(announcement);
+    }
+
+    @NonNull @Override public CardType type() {
+        return CardType.ONBOARDING_CUSTOMIZE_FEED;
+    }
+
+    public boolean shouldShow() {
+        return super.shouldShow() && !AccountUtil.isLoggedIn();
+    }
+
+    @Override
+    public int prefKey() {
+        return 
R.string.preference_key_feed_readinglists_sync_onboarding_card_enabled;
+    }
+}
diff --git a/app/src/main/res/values/preference_keys.xml 
b/app/src/main/res/values/preference_keys.xml
index 7880742..f973c1f 100644
--- a/app/src/main/res/values/preference_keys.xml
+++ b/app/src/main/res/values/preference_keys.xml
@@ -69,6 +69,7 @@
     <string name="preference_key_feed_cards_order">feedCardsOrder</string>
     <string name="preference_key_feed_cards_enabled">feedCardsEnabled</string>
     <string 
name="preference_key_feed_customize_onboarding_card_enabled">feedCustomizeOnboardingCardEnabled</string>
+    <string 
name="preference_key_feed_readinglists_sync_onboarding_card_enabled">feedReadingListsSyncOnboardingCardEnabled</string>
     <string name="preference_key_add_articles">addArticles</string>
     <string name="preference_key_add_reading_lists">addReadingLists</string>
     <string 
name="preference_key_reading_lists_last_sync_time">readingListsLastSyncTime</string>
diff --git a/app/src/main/res/values/strings.xml 
b/app/src/main/res/values/strings.xml
index ff8cd71..a9b00e9 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -387,6 +387,7 @@
     <string name="split_reading_list_message">There is a limit of 1000 
articles per reading list. Existing lists with more than this limit have been 
split into multiple lists.</string>
     <string name="reading_list_article_limit_message">Can\'t add to this list. 
You\'ve reached the limit of 1,000 articles per list for \"%s\".</string>
     <string name="reading_lists_limit_message">Can\'t create another list. 
You\'ve reached the limit of 100 reading lists per account.</string>
+    <string 
name="feed_reading_lists_sync_onboarding_text"><![CDATA[<strong>Sync reading 
lists</strong><br /><br />Reading lists can now be synced across devices. Login 
to your Wikipedia account and allow your lists to be saved to your user 
preferences.]]></string>
     <plurals name="reading_list_article_offline_message">
         <item quantity="one">This article will now be available offline.</item>
         <item quantity="other">These articles will now be available 
offline.</item>

-- 
To view, visit https://gerrit.wikimedia.org/r/405020
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia60dec7cc7490d6bbf77978d785bef663072a758
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Sharvaniharan <sha...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits