Umherirrender has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404880 )
Change subject: Add PHP_CodeSniffer for codestyle checks to SendGrid extension
......................................................................
Add PHP_CodeSniffer for codestyle checks to SendGrid extension
Bug: T185159
Change-Id: I137a88c48739936e752c2b909a35e5b166d50bd4
---
A .phpcs.xml
M SendGrid.php
M composer.json
3 files changed, 15 insertions(+), 2 deletions(-)
Approvals:
Umherirrender: Verified; Looks good to me, approved
D3r1ck01: Looks good to me, but someone else must approve
diff --git a/.phpcs.xml b/.phpcs.xml
new file mode 100644
index 0000000..b15894e
--- /dev/null
+++ b/.phpcs.xml
@@ -0,0 +1,11 @@
+<?xml version="1.0"?>
+<ruleset>
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
+ <exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
+ </rule>
+ <file>.</file>
+ <arg name="extensions" value="php,php5,inc" />
+ <arg name="encoding" value="UTF-8" />
+</ruleset>
diff --git a/SendGrid.php b/SendGrid.php
index a11fe97..5db9cd7 100644
--- a/SendGrid.php
+++ b/SendGrid.php
@@ -11,4 +11,4 @@
return;
} else {
die( 'This version of the SendGrid extension requires MediaWiki 1.25+'
);
-}
\ No newline at end of file
+}
diff --git a/composer.json b/composer.json
index ca92d26..149ad7f 100644
--- a/composer.json
+++ b/composer.json
@@ -7,17 +7,19 @@
},
"require-dev": {
"phpunit/phpunit": "4.*",
- "squizlabs/php_codesniffer": "2.*",
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
+ "mediawiki/mediawiki-codesniffer": "15.0.0",
"mediawiki/minus-x": "0.2.1"
},
"scripts": {
"test": [
"parallel-lint . --exclude vendor --exclude
node_modules",
+ "phpcs -p -s",
"minus-x check ."
],
"fix": [
+ "phpcbf",
"minus-x fix ."
]
},
--
To view, visit https://gerrit.wikimedia.org/r/404880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I137a88c48739936e752c2b909a35e5b166d50bd4
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/SendGrid
Gerrit-Branch: master
Gerrit-Owner: Phantom42 <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Brian Wolff <[email protected]>
Gerrit-Reviewer: D3r1ck01 <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
