jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/405042 )

Change subject: noindex,nofollow the 'access denied' topic page
......................................................................


noindex,nofollow the 'access denied' topic page

When a topic has been deleted or suppressed, the 'access denied'
page will be 'noindex,nofollow' instead of the error it currenty shows.

Change-Id: I5da9299fcd2aa1e6a7a951f636ffb68f8556876f
---
M includes/View.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/View.php b/includes/View.php
index f1284e8..16ece1d 100644
--- a/includes/View.php
+++ b/includes/View.php
@@ -93,7 +93,8 @@
                if ( $workflow->getType() === 'topic' ) {
                        /** @var TopicBlock $topic */
                        $topic = $blocks[ 'topic' ];
-                       if ( $topic->loadTopicTitle()->isHidden() ) {
+                       $topicRev = $topic->loadTopicTitle();
+                       if ( !$topicRev || $topicRev->isHidden() ) {
                                return [
                                        'index' => 'noindex',
                                        'follow' => 'nofollow',

-- 
To view, visit https://gerrit.wikimedia.org/r/405042
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5da9299fcd2aa1e6a7a951f636ffb68f8556876f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to