Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405066 )

Change subject: Fix phpdoc since $proto can be int
......................................................................

Fix phpdoc since $proto can be int

In fact, all PROTO_* constants are ints.

Change-Id: I69c45ab87360ed1ab54b53b7e9e959ea566b4cba
---
M includes/GlobalFunctions.php
M includes/Title.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/66/405066/1

diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index b0057eb..328a1a3 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -582,7 +582,7 @@
  * like "subdir/foo.html", etc.
  *
  * @param string $url Either fully-qualified or a local path + query
- * @param string $defaultProto One of the PROTO_* constants. Determines the
+ * @param string|int $defaultProto One of the PROTO_* constants. Determines the
  *    protocol to use if $url or $wgServer is protocol-relative
  * @return string|false Fully-qualified URL, current-path-relative URL or 
false if
  *    no valid URL can be constructed
diff --git a/includes/Title.php b/includes/Title.php
index 3de85e1..ccc2fd2 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -1769,7 +1769,7 @@
         * @see wfExpandUrl
         * @param string|string[] $query
         * @param string|string[]|bool $query2
-        * @param string $proto Protocol type to use in URL
+        * @param string|int $proto Protocol type to use in URL
         * @return string The URL
         */
        public function getFullURL( $query = '', $query2 = false, $proto = 
PROTO_RELATIVE ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/405066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69c45ab87360ed1ab54b53b7e9e959ea566b4cba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Smalyshev <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to