jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/402854 )
Change subject: Replace ArrayIterator with more trivial PageEntityUsages[]
......................................................................
Replace ArrayIterator with more trivial PageEntityUsages[]
I might miss something, but I don't see the point in wrapping this
array in an ArrayIterator. Maybe the functionality of ArrayIterator
was used in the past, but currently it's unused. The only code path
that consumes this array iterates it. That's all.
Change-Id: I8e7750075c5bb1d2efd9b475c36b3e5eca7c3b6e
---
M client/includes/Changes/AffectedPagesFinder.php
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Ladsgroup: Looks good to me, approved
Uzume: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/client/includes/Changes/AffectedPagesFinder.php
b/client/includes/Changes/AffectedPagesFinder.php
index 8c2d502..02e39bd 100644
--- a/client/includes/Changes/AffectedPagesFinder.php
+++ b/client/includes/Changes/AffectedPagesFinder.php
@@ -101,7 +101,7 @@
/**
* @param Change $change
*
- * @return ArrayIterator of PageEntityUsage
+ * @return PageEntityUsages[]
*/
public function getAffectedUsagesByPage( Change $change ) {
if ( $change instanceof EntityChange ) {
@@ -109,7 +109,7 @@
return $this->filterUpdates( $usages );
}
- return new ArrayIterator();
+ return [];
}
/**
@@ -304,7 +304,7 @@
*
* @param Traversable $usages A traversable of PageEntityUsages.
*
- * @return ArrayIterator of PageEntityUsages
+ * @return PageEntityUsages[]
*/
private function filterUpdates( Traversable $usages ) {
$titlesToUpdate = [];
@@ -326,7 +326,7 @@
$titlesToUpdate[$key] = $pageEntityUsages;
}
- return new ArrayIterator( $titlesToUpdate );
+ return $titlesToUpdate;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/402854
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e7750075c5bb1d2efd9b475c36b3e5eca7c3b6e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <thiemo.kr...@wikimedia.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <lucas.werkmeis...@wikimedia.de>
Gerrit-Reviewer: Uzume <uz...@users.sourceforge.net>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
