jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403733 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I66c80966b9c826819f3985630720a7078e7326ef
---
M .phpcs.xml
M includes/Hooks.php
2 files changed, 3 insertions(+), 6 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.phpcs.xml b/.phpcs.xml
index 6ad584b..06b0951 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -3,8 +3,6 @@
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
<exclude name="Squiz.Scope.MethodScope.Missing" />
@@ -12,5 +10,4 @@
<file>.</file>
<arg name="extensions" value="php,php5,inc"/>
<arg name="encoding" value="UTF-8"/>
- <exclude-pattern>vendor</exclude-pattern>
</ruleset>
diff --git a/includes/Hooks.php b/includes/Hooks.php
index 15d71b8..2f4a3f5 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -104,8 +104,8 @@
/**
* If an IP address is blacklisted, don't let them edit.
*
- * @param Title $title Title being acted upon
- * @param User $user User performing the action
+ * @param Title &$title Title being acted upon
+ * @param User &$user User performing the action
* @param string $action Action being performed
* @param array &$result Will be filled with block status if blocked
* @return bool
@@ -162,7 +162,7 @@
}
/**
- * @param array $msg
+ * @param array &$msg
* @param string $ip
* @return bool
*/
--
To view, visit https://gerrit.wikimedia.org/r/403733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66c80966b9c826819f3985630720a7078e7326ef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/StopForumSpam
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
