jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403732 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I7a40173b54998a3a34fbf2d294c1f71d6ccd61a3
---
M .phpcs.xml
M BaseHooks.hooks.php
2 files changed, 2 insertions(+), 5 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.phpcs.xml b/.phpcs.xml
index c17605e..2b3c5a5 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,14 +2,11 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
- <arg name="encoding" value="utf8" />
- <exclude-pattern>vendor</exclude-pattern>
+ <arg name="encoding" value="UTF-8" />
<exclude-pattern>tests/test.inc</exclude-pattern>
</ruleset>
diff --git a/BaseHooks.hooks.php b/BaseHooks.hooks.php
index ea3e04c..5e1dcdd 100644
--- a/BaseHooks.hooks.php
+++ b/BaseHooks.hooks.php
@@ -3,7 +3,7 @@
class BaseHooksHooks {
/**
* @param Skin $skin
- * @param string $text
+ * @param string &$text
* @return bool
*/
public static function onSkinAfterBottomScripts( Skin $skin, &$text =
'' ) {
--
To view, visit https://gerrit.wikimedia.org/r/403732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a40173b54998a3a34fbf2d294c1f71d6ccd61a3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BaseHooks
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
