jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403741 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: Id7411295a7c1b2462f1e73efc52d5df8d2d3f750
---
M .phpcs.xml
M PagePopups.hooks.php
2 files changed, 3 insertions(+), 6 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.phpcs.xml b/.phpcs.xml
index 4077be7..5c2c9f8 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,14 +2,11 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
- <arg name="encoding" value="utf8" />
- <exclude-pattern>vendor</exclude-pattern>
+ <arg name="encoding" value="UTF-8" />
<exclude-pattern>tests/test.inc</exclude-pattern>
</ruleset>
diff --git a/PagePopups.hooks.php b/PagePopups.hooks.php
index 718ae2a..5ef304b 100644
--- a/PagePopups.hooks.php
+++ b/PagePopups.hooks.php
@@ -2,8 +2,8 @@
class PagePopupsHooks {
/**
- * @param Skin $skin
- * @param string $text
+ * @param OutputPage &$out
+ * @param Skin &$skin
* @return bool
*/
public static function onBeforePageDisplay( OutputPage &$out, Skin
&$skin ) {
--
To view, visit https://gerrit.wikimedia.org/r/403741
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7411295a7c1b2462f1e73efc52d5df8d2d3f750
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PagePopups
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
