jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403709 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: Ie735da8dfffa57129d8a2e1bd8156af1080fd9ff
---
M .phpcs.xml
M TweetANew.body.php
M TweetANew.php
3 files changed, 16 insertions(+), 17 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.phpcs.xml b/.phpcs.xml
index 25901c7..0b6785e 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,8 +2,7 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="Generic.Files.LineLength.TooLong" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<exclude
name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
diff --git a/TweetANew.body.php b/TweetANew.body.php
index 1ac1358..7c9fce1 100644
--- a/TweetANew.body.php
+++ b/TweetANew.body.php
@@ -14,9 +14,9 @@
/**
* Function for tweeting new wiki pages
*
- * @param $wikiPage WikiPage
- * @param $user User
- * @param $summary
+ * @param WikiPage $wikiPage
+ * @param User $user
+ * @param string $summary
*
* @return bool
*/
@@ -87,11 +87,11 @@
/**
* Function for tweeting edited articles
*
- * @param $wikiPage WikiPage
- * @param $user User
- * @param $content Content
- * @param $summary string
- * @param $isMinor bool
+ * @param WikiPage $wikiPage
+ * @param User $user
+ * @param Content $content
+ * @param string $summary
+ * @param bool $isMinor
*
* @return bool
*/
@@ -216,7 +216,7 @@
/**
* Function shortening url via outside service or leaving for t.co
service if none are enabled
*
- * @param $longurl
+ * @param string $longurl
*
* @return string
*/
@@ -249,9 +249,9 @@
/**
* Function for connecting to Twitter, preparing and then sending tweet
*
- * @param $wikiPage WikiPage
- * @param $tweet_text
- * @param $finalurl
+ * @param WikiPage $wikiPage
+ * @param string $tweet_text
+ * @param string $finalurl
*
* @return bool
*/
diff --git a/TweetANew.php b/TweetANew.php
index 838cfc1..bb7e31b 100644
--- a/TweetANew.php
+++ b/TweetANew.php
@@ -211,9 +211,9 @@
/**
* Function for tweeting about new or edited articles when auto-tweet if
disabled
*
- * @param $editpage
- * @param $checkboxes
- * @param $tabindex
+ * @param EditPage $editpage
+ * @param array &$checkboxes
+ * @param null|int &$tabindex
*
* @return bool
*/
--
To view, visit https://gerrit.wikimedia.org/r/403709
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie735da8dfffa57129d8a2e1bd8156af1080fd9ff
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TweetANew
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
