jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403739 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I7702c3019bd003e6ba79266c217c04961e007767
---
M .phpcs.xml
M includes/OOJsUIAjaxLogin.hooks.php
2 files changed, 3 insertions(+), 6 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.phpcs.xml b/.phpcs.xml
index 91829ee..90e8108 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,12 +2,9 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
- <arg name="encoding" value="utf8" />
- <exclude-pattern>vendor</exclude-pattern>
+ <arg name="encoding" value="UTF-8" />
</ruleset>
diff --git a/includes/OOJsUIAjaxLogin.hooks.php
b/includes/OOJsUIAjaxLogin.hooks.php
index 9bad91b..6fd52d7 100644
--- a/includes/OOJsUIAjaxLogin.hooks.php
+++ b/includes/OOJsUIAjaxLogin.hooks.php
@@ -4,8 +4,8 @@
/**
* BeforePageDisplay hook handler. Add the required module for this
extension.
*
- * @param OutputPage $out
- * @param Skin $sk
+ * @param OutputPage &$out
+ * @param Skin &$sk
*/
public static function onBeforePageDisplay( OutputPage &$out, Skin &$sk
) {
if ( !$out->getUser()->isLoggedIn() ) {
--
To view, visit https://gerrit.wikimedia.org/r/403739
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7702c3019bd003e6ba79266c217c04961e007767
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/OOJsUIAjaxLogin
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
