Ottomata has submitted this change and it was merged.

Change subject: MongoDB: don't fork; let upstart drive.
......................................................................


MongoDB: don't fork; let upstart drive.

Currently 'initctl status mongodb' always reports a status of 'stop/waiting'
for MongoDB. Consequently, every time Puppet runs, it thinks MongoDB has
stopped and it restarts it. This is because MongoDB has been configured to
daemonize, but the upstart configuration does not include an "expect daemon"
statement, so it loses track of the process. The solution is either to add
"expect daemon" to the upstart config or to tell MongoDB not to fork and
instead allow upstart to daemonize it. I went with the latter approach because
it was easy to do using our current MongoDB module structure.

Change-Id: I73cf30d9a2e8eb04ce38013539c0a23b90e5459d
---
M manifests/misc/statistics.pp
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Ottomata: Verified; Looks good to me, approved



diff --git a/manifests/misc/statistics.pp b/manifests/misc/statistics.pp
index 26d4787..c0a884f 100644
--- a/manifests/misc/statistics.pp
+++ b/manifests/misc/statistics.pp
@@ -429,7 +429,8 @@
 # installs MonogDB on stat1
 class misc::statistics::db::mongo {
        class { "mongodb":
-               dbpath => "/a/mongodb",
+               mongofork => false,
+               dbpath    => "/a/mongodb",
        }
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/58225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I73cf30d9a2e8eb04ce38013539c0a23b90e5459d
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to