jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405220 )
Change subject: Fix: Random Cards never load when swiped quickly ...................................................................... Fix: Random Cards never load when swiped quickly -Logic added to load card data if it wasn't previously loaded. Bug: T184868 Change-Id: I8ae58682f8e1f744cb06bb7112128a988ce1e702 --- M app/src/main/java/org/wikipedia/random/RandomItemFragment.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Dbrant: Looks good to me, approved jenkins-bot: Verified diff --git a/app/src/main/java/org/wikipedia/random/RandomItemFragment.java b/app/src/main/java/org/wikipedia/random/RandomItemFragment.java index 254c16c..3edf683 100644 --- a/app/src/main/java/org/wikipedia/random/RandomItemFragment.java +++ b/app/src/main/java/org/wikipedia/random/RandomItemFragment.java @@ -69,7 +69,7 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { super.onCreateView(inflater, container, savedInstanceState); - if (view == null) { + if (view == null || !containsData()) { view = inflater.inflate(R.layout.fragment_random_item, container, false); ButterKnife.bind(this, view); imageView.setLegacyVisibilityHandlingEnabled(true); @@ -84,6 +84,10 @@ return view; } + private boolean containsData() { + return !(TextUtils.isEmpty(articleTitleView.getText().toString()) || TextUtils.isEmpty(extractView.getText().toString())); + } + private void getRandomPage() { new RandomSummaryClient().request(WikipediaApp.getInstance().getWikiSite(), new RandomSummaryClient.Callback() { @Override -- To view, visit https://gerrit.wikimedia.org/r/405220 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ae58682f8e1f744cb06bb7112128a988ce1e702 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Sharvaniharan <sha...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Cooltey <cf...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits