jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/405204 )
Change subject: Replace deprecated 'alert' indicator with similar icon
......................................................................
Replace deprecated 'alert' indicator with similar icon
Follow-up to I03db8b069bf6c0f66148fc92ed9f21d28b2135e6
Note, that 'notice' icon has the same visual appearance
(aside of a tad bigger canvas) as 'alert' and
in this case an IconWidget is actually the widget we
want anyways.
Bug: T185158
Change-Id: I19c3be307dec71992cea984bfbbbeb4f15d1a0b9
---
M
modules/editor/editors/visualeditor/ui/inspectors/mw.flow.ve.ui.MentionInspector.js
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/modules/editor/editors/visualeditor/ui/inspectors/mw.flow.ve.ui.MentionInspector.js
b/modules/editor/editors/visualeditor/ui/inspectors/mw.flow.ve.ui.MentionInspector.js
index 562c073..fd74925 100644
---
a/modules/editor/editors/visualeditor/ui/inspectors/mw.flow.ve.ui.MentionInspector.js
+++
b/modules/editor/editors/visualeditor/ui/inspectors/mw.flow.ve.ui.MentionInspector.js
@@ -152,7 +152,7 @@
* Initialize UI of inspector
*/
mw.flow.ve.ui.MentionInspector.prototype.initialize = function () {
- var flowBoard, overlay, indicatorWidget;
+ var flowBoard, overlay, iconWidget;
mw.flow.ve.ui.MentionInspector.parent.prototype.initialize.call( this );
@@ -170,10 +170,10 @@
$overlay: overlay ? overlay.$element : this.$frame,
topicPosters: flowBoard.getTopicPosters( this.$element )
} );
- indicatorWidget = new OO.ui.IndicatorWidget( {
- indicator: 'alert'
+ iconWidget = new OO.ui.IconWidget( {
+ icon: 'notice'
} );
- this.errorWidget = new OO.ui.FieldLayout( indicatorWidget, {
+ this.errorWidget = new OO.ui.FieldLayout( iconWidget, {
align: 'inline'
} );
this.errorFieldsetLayout = new OO.ui.FieldsetLayout( {
--
To view, visit https://gerrit.wikimedia.org/r/405204
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19c3be307dec71992cea984bfbbbeb4f15d1a0b9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
