Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405346 )
Change subject: Fix: check old revision for deletion when diffing
......................................................................
Fix: check old revision for deletion when diffing
When determining whether to show a "You cannot view this diff because
one of the revisions has been deleted." message, consider the "old"
revision in addition to the "new" revision. This check is also present
in the superclass, DifferenceEngine, but not inherited in its subclass,
InlineDifferenceEngine.
Bug: T101796
Change-Id: I0cf8fee84640235b24c0459c9b3eabae6cb35d4b
---
M includes/diff/InlineDifferenceEngine.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/46/405346/1
diff --git a/includes/diff/InlineDifferenceEngine.php
b/includes/diff/InlineDifferenceEngine.php
index 015ea6a..6ac8fc8 100644
--- a/includes/diff/InlineDifferenceEngine.php
+++ b/includes/diff/InlineDifferenceEngine.php
@@ -12,7 +12,8 @@
* @return bool
*/
public function isDeletedDiff() {
- return $this->mNewRev && $this->mNewRev->isDeleted(
Revision::DELETED_TEXT );
+ return $this->mNewRev && $this->mNewRev->isDeleted(
Revision::DELETED_TEXT ) ||
+ $this->mOldRev && $this->mOldRev->isDeleted(
Revision::DELETED_TEXT );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/405346
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cf8fee84640235b24c0459c9b3eabae6cb35d4b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
