jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404585 )

Change subject: Fix help menu icon placement for monobook
......................................................................


Fix help menu icon placement for monobook

Bug: T184023
Change-Id: I6aa356624c7d9532fc69503f0ab99f0511fc30dc
---
M modules/styles/mw.echo.ui.SpecialHelpMenuWidget.less
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/styles/mw.echo.ui.SpecialHelpMenuWidget.less 
b/modules/styles/mw.echo.ui.SpecialHelpMenuWidget.less
index 779b89d..7d49498 100644
--- a/modules/styles/mw.echo.ui.SpecialHelpMenuWidget.less
+++ b/modules/styles/mw.echo.ui.SpecialHelpMenuWidget.less
@@ -25,6 +25,13 @@
                        padding: 0.5em;
                        margin-right: 0;
 
+                       .oo-ui-buttonElement-button .oo-ui-iconElement-icon {
+                               // OOUI Apex sets 'display:block;' with a huge 
level of specificity
+                               // on this icon. We must override it otherwise 
it sticks on its
+                               // own line
+                               display: inline-block !important;
+                       }
+
                        .oo-ui-labelElement-label {
                                white-space: normal;
                                // Width of the popup (300px) minus the

-- 
To view, visit https://gerrit.wikimedia.org/r/404585
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6aa356624c7d9532fc69503f0ab99f0511fc30dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to