Catrope has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/405251 )
Change subject: Hide hamburger button from assistive technologies
......................................................................
Hide hamburger button from assistive technologies
In current architecture, the hamburger button is only useful for
graphical user interface users. As the menu is before or after the
button anyways, we don't need to expose it to screenreader users.
Bug: T185288
Change-Id: Ie646d6df97264412f5cf8f19aef60869490caa16
---
M 2017/community.html
M 2017/donors.html
M 2017/financials.html
M 2017/index.html
M 2017/leadership.html
M 2017/stories.html
6 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Catrope: Verified; Looks good to me, approved
diff --git a/2017/community.html b/2017/community.html
index 9ba3ec2..350329b 100644
--- a/2017/community.html
+++ b/2017/community.html
@@ -68,7 +68,7 @@
</ul>
</nav>
</div>
- <button class="hamburger hamburger--squeeze js-hamburger"
type="button"><span class="hamburger-box"><span
class="hamburger-inner"></span></span></button>
+ <button class="hamburger hamburger--squeeze js-hamburger"
type="button" aria-hidden="true"><span class="hamburger-box"><span
class="hamburger-inner"></span></span></button>
</div>
</header>
<div class="nav--mobile js-mobile-nav">
diff --git a/2017/donors.html b/2017/donors.html
index 1f7e50d..dd709f6 100644
--- a/2017/donors.html
+++ b/2017/donors.html
@@ -68,7 +68,7 @@
</ul>
</nav>
</div>
- <button class="hamburger hamburger--squeeze js-hamburger"
type="button"><span class="hamburger-box"><span
class="hamburger-inner"></span></span></button>
+ <button class="hamburger hamburger--squeeze js-hamburger"
type="button" aria-hidden="true"><span class="hamburger-box"><span
class="hamburger-inner"></span></span></button>
</div>
</header>
<div class="nav--mobile js-mobile-nav">
diff --git a/2017/financials.html b/2017/financials.html
index 06e7bc2..ed02317 100644
--- a/2017/financials.html
+++ b/2017/financials.html
@@ -68,7 +68,7 @@
</ul>
</nav>
</div>
- <button class="hamburger hamburger--squeeze js-hamburger"
type="button"><span class="hamburger-box"><span
class="hamburger-inner"></span></span></button>
+ <button class="hamburger hamburger--squeeze js-hamburger"
type="button" aria-hidden="true"><span class="hamburger-box"><span
class="hamburger-inner"></span></span></button>
</div>
</header>
<div class="nav--mobile js-mobile-nav">
diff --git a/2017/index.html b/2017/index.html
index 53f33b2..12cc3d4 100755
--- a/2017/index.html
+++ b/2017/index.html
@@ -68,7 +68,7 @@
</ul>
</nav>
</div>
- <button class="hamburger hamburger--squeeze js-hamburger"
type="button"><span class="hamburger-box"><span
class="hamburger-inner"></span></span></button>
+ <button class="hamburger hamburger--squeeze js-hamburger"
type="button" aria-hidden="true"><span class="hamburger-box"><span
class="hamburger-inner"></span></span></button>
</div>
</header>
<div class="nav--mobile js-mobile-nav">
diff --git a/2017/leadership.html b/2017/leadership.html
index 53f8503..b5b2fd9 100644
--- a/2017/leadership.html
+++ b/2017/leadership.html
@@ -68,7 +68,7 @@
</ul>
</nav>
</div>
- <button class="hamburger hamburger--squeeze js-hamburger"
type="button"><span class="hamburger-box"><span
class="hamburger-inner"></span></span></button>
+ <button class="hamburger hamburger--squeeze js-hamburger"
type="button" aria-hidden="true"><span class="hamburger-box"><span
class="hamburger-inner"></span></span></button>
</div>
</header>
<div class="nav--mobile js-mobile-nav">
diff --git a/2017/stories.html b/2017/stories.html
index 3fe067c..69137c7 100644
--- a/2017/stories.html
+++ b/2017/stories.html
@@ -68,7 +68,7 @@
</ul>
</nav>
</div>
- <button class="hamburger hamburger--squeeze js-hamburger"
type="button"><span class="hamburger-box"><span
class="hamburger-inner"></span></span></button>
+ <button class="hamburger hamburger--squeeze js-hamburger"
type="button" aria-hidden="true"><span class="hamburger-box"><span
class="hamburger-inner"></span></span></button>
</div>
</header>
<div class="nav--mobile js-mobile-nav">
--
To view, visit https://gerrit.wikimedia.org/r/405251
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie646d6df97264412f5cf8f19aef60869490caa16
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/annualreport
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
